[bug] Exception Thrown When Using `waitForApproval` Component

[monikakuster]

An exception is thrown when the waitForApproval component is used in a workflow.

Steps to Reproduce:
https://github.com/user-attachments/assets/8f23ebf4-bf60-4a7d-bd9f-1137c185ede3

Exception trace:

org.springframework.jms.listener.adapter.ListenerExecutionFailedException: Listener method 'onApplicationEvent' threw exception
	at org.springframework.jms.listener.adapter.MessageListenerAdapter.invokeListenerMethod(MessageListenerAdapter.java:303)
	at org.springframework.jms.listener.adapter.MessageListenerAdapter.onMessage(MessageListenerAdapter.java:223)
	at org.springframework.jms.listener.AbstractMessageListenerContainer.doInvokeListener(AbstractMessageListenerContainer.java:819)
	at org.springframework.jms.listener.AbstractMessageListenerContainer.invokeListener(AbstractMessageListenerContainer.java:776)
	at org.springframework.jms.listener.AbstractMessageListenerContainer.doExecuteListener(AbstractMessageListenerContainer.java:754)
	at org.springframework.jms.listener.AbstractPollingMessageListenerContainer.doReceiveAndExecute(AbstractPollingMessageListenerContainer.java:333)
	at org.springframework.jms.listener.AbstractPollingMessageListenerContainer.receiveAndExecute(AbstractPollingMessageListenerContainer.java:270)
	at org.springframework.jms.listener.DefaultMessageListenerContainer$AsyncMessageListenerInvoker.invokeListener(DefaultMessageListenerContainer.java:1420)
	at org.springframework.jms.listener.DefaultMessageListenerContainer$AsyncMessageListenerInvoker.executeOngoingLoop(DefaultMessageListenerContainer.java:1410)
	at org.springframework.jms.listener.DefaultMessageListenerContainer$AsyncMessageListenerInvoker.run(DefaultMessageListenerContainer.java:1287)
	at java.base/java.lang.Thread.run(Thread.java:1474)
Caused by: java.lang.IllegalArgumentException: null
	at com.bytechef.platform.notification.domain.NotificationEvent$Type.of(NotificationEvent.java:54)
	at com.bytechef.platform.coordinator.event.listener.NotificationJobStatusApplicationEventListener.onApplicationEvent(NotificationJobStatusApplicationEventListener.java:75)
	at com.bytechef.atlas.coordinator.TaskCoordinator.onApplicationEvent(TaskCoordinator.java:98)
	at com.bytechef.atlas.coordinator.config.TaskCoordinatorMessageBrokerConfigurerConfiguration$TaskCoordinatorDelegate.onApplicationEvent(TaskCoordinatorMessageBrokerConfigurerConfiguration.java:94)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at org.springframework.util.MethodInvoker.invoke(MethodInvoker.java:286)
	at org.springframework.jms.listener.adapter.MessageListenerAdapter.invokeListenerMethod(MessageListenerAdapter.java:295)
	... 10 common frames omitted

[igorbeslic]

@monikakuster @matijapetanjek and @ivicac I see... waitForApproval brings STOPPED status... Which is not defined in com.bytechef.platform.notification.domain.NotificationEvent.Type

PLease, can you consider to call that event:
JOB_PAUSED or JOB_WAITING or just WAITING (Keap It Simple Stupid :)

I wote for JOB_WAITING - makes the most sense for me. I wanted to fix this immediately but I believe we have to agree about good name for state of waiting for approval....

@matijapetanjek can we update IllegalArgumentException

public static Type of(Source source, String value) {
            for (Type type : values()) {
                if (source == type.source && value.equals(type.value)) {
                    return type;
                }
            }

            throw new IllegalArgumentException();
        }

To send message :

IllegalArgumentException(String.format("Invalid source %s and value %s", source, value))