allow multiple IPs in config [#17]

Author: dnl-blkv

BunqSdk.Tests/BunqSdkTestBase.cs

@@ -24,7 +24,7 @@ public class BunqSdkTestBase
         /// Configuration items.
         /// </summary>
         private static readonly string API_KEY = Config.GetApiKey();
-        private static readonly string FIELD_PERMITTED_IP = Config.GetPermittedIp();
+        private static readonly string[] FIELD_PERMITTED_IPS = Config.GetPermittedIps();
 
         /// <summary>
         /// Gets an Api Context, re-creates if needed and returns it.
@@ -54,9 +54,8 @@ protected static ApiContext GetApiContext()
 
         private static ApiContext CreateApiContext()
         {
-            var permittedIps = new List<string> {FIELD_PERMITTED_IP};
-
-            return ApiContext.Create(ApiEnvironmentType.SANDBOX, API_KEY, DEVICE_DESCRIPTION_TEST, permittedIps);
+            return ApiContext.Create(ApiEnvironmentType.SANDBOX, API_KEY, DEVICE_DESCRIPTION_TEST,
+                new List<string>(FIELD_PERMITTED_IPS));
         }
     }
 }

BunqSdk.Tests/Config.cs

@@ -1,15 +1,29 @@
-using System.IO;
+using System.Collections.Immutable;
+using System.IO;
 using Bunq.Sdk.Model.Generated.Object;
 using Newtonsoft.Json.Linq;
 
 namespace Bunq.Sdk.Tests
 {
     public class Config
     {
+        /// <summary>
+        /// Delimiter between the IP addresses in the PERMITTED_IPS field.
+        /// </summary>
+        private const char DELIMITER_IPS = ',';
+
+        /// <summary>
+        /// Length of an empty array.
+        /// </summary>
+        private const int LENGTH_NONE = 0;
+
+        /// <summary>
+        /// Field constants.
+        /// </summary>
         private const string FIELD_CONFIG_FILE_PATH = "../../../Resources/config.json";
         private const string FIELD_USER_ID = "USER_ID";
         private const string FIELD_API_KEY = "API_KEY";
-        private const string FIELD_PERMITTED_IP = "ipAddress";
+        private const string FIELD_PERMITTED_IPS = "PERMITTED_IPS";
         private const string FIELD_ATTACHMENT_PUBLIC_TEST = "AttachmentPublicTest";
         private const string FIELD_ATTACHMENT_PATH_IN = "PATH_IN";
         private const string FIELD_ATTACHMENT_DESCRIPTION = "DESCRIPTION";
@@ -69,9 +83,13 @@ public static string GetAttachmentContentType()
             return GetConfig()[FIELD_ATTACHMENT_PUBLIC_TEST][FIELD_ATTACHMENT_CONTENT_TYPE].ToString();
         }
 
-        public static string GetPermittedIp()
+        public static string[] GetPermittedIps()
         {
-            return GetConfig()[FIELD_PERMITTED_IP].ToString();
+            var permittedIpsString = GetConfig()[FIELD_PERMITTED_IPS].ToString();
+
+            return permittedIpsString.Length == LENGTH_NONE ?
+                new string[LENGTH_NONE] :
+                permittedIpsString.Split(DELIMITER_IPS);
         }
 
         public static string GetApiKey()

BunqSdk.Tests/Resources/config.example.json

@@ -3,7 +3,7 @@
     "USER_ID": "XXXX",
     "MONETARY_ACCOUNT_ID": "XXXX",
     "MONETARY_ACCOUNT_ID2": "XXXX",
-    "ipAddress": "<ip address>",
+    "PERMITTED_IPS": "<ip address>,<another ip address>",
     "AttachmentPublicTest": {
         "CONTENT_TYPE": "image/png",
         "DESCRIPTION": "TEST PNG PHP",