Rename constants following group identifier and PascalCase convention. (#58)

Author: Joao Antao

BunqSdk.Tests/Model/Generated/Endpoint/MonetaryAccountBankTest.cs

@@ -14,12 +14,12 @@ public class MonetaryAccountBankTest : BunqSdkTestBase
         /// <summary>
         /// Config values
         /// </summary>
-        private const string Status = "CANCELLED";
-        private const string SubStatus = "REDEMPTION_VOLUNTARY";
-        private const string Reason = "OTHER";
-        private const string ReasonDescription = "Because this is a test";
-        private const string Currency = "EUR";
-        private const string Description = "Test C# monetary account";
+        private const string MonetaryAccountBankStatus = "CANCELLED";
+        private const string MonetaryAccountBankSubStatus = "REDEMPTION_VOLUNTARY";
+        private const string MonetaryAccountBankReason = "OTHER";
+        private const string MonetaryAccountBankReasonDescription = "Because this is a test";
+        private const string MonetaryAccountBankCurrency = "EUR";
+        private const string MonetaryAccountBankDescription = "Test C# monetary account";
 
         private static readonly int UserId = Config.GetUserId();
 
@@ -36,8 +36,8 @@ public void TestCreationNewMonetaryAccount()
         {
             var requestMap = new Dictionary<string, object>
             {
-                {MonetaryAccountBank.FIELD_CURRENCY, Currency},
-                {MonetaryAccountBank.FIELD_DESCRIPTION, Description}
+                {MonetaryAccountBank.FIELD_CURRENCY, MonetaryAccountBankCurrency},
+                {MonetaryAccountBank.FIELD_DESCRIPTION, MonetaryAccountBankDescription}
             };
             var monetaryAccountToCloseId = MonetaryAccountBank.Create(ApiContext, requestMap, UserId).Value;
 
@@ -48,10 +48,10 @@ private static void DeleteMonetaryAccount(int idToClose)
         {
             var requestMap = new Dictionary<string, object>
             {
-                {MonetaryAccountBank.FIELD_STATUS, Status},
-                {MonetaryAccountBank.FIELD_SUB_STATUS, SubStatus},
-                {MonetaryAccountBank.FIELD_REASON, Reason},
-                {MonetaryAccountBank.FIELD_REASON_DESCRIPTION, ReasonDescription}
+                {MonetaryAccountBank.FIELD_STATUS, MonetaryAccountBankStatus},
+                {MonetaryAccountBank.FIELD_SUB_STATUS, MonetaryAccountBankSubStatus},
+                {MonetaryAccountBank.FIELD_REASON, MonetaryAccountBankReason},
+                {MonetaryAccountBank.FIELD_REASON_DESCRIPTION, MonetaryAccountBankReasonDescription}
             };
             MonetaryAccountBank.Update(ApiContext, requestMap, UserId, idToClose);
         }

BunqSdk.Tests/Model/Generated/Endpoint/PaymentChatTest.cs

@@ -17,10 +17,10 @@ public class PaymentChatTest : BunqSdkTestBase
         /// <summary>
         /// Config values.
         /// </summary>
-        private const string Amount = "0.01";
-        private const string Currency = "EUR";
-        private const string Description = "Payment From C# Test";
-        private const string Text = "test msg send from C# test";
+        private const string PaymentChatAmountEur = "0.01";
+        private const string PaymentChatCurrency = "EUR";
+        private const string PaymentChatDescription = "Payment From C# Test";
+        private const string PaymentChatText = "test msg send from C# test";
 
         private static readonly int UserId = Config.GetUserId();
         private static readonly int MonetaryAccountId = Config.GetMonetarytAccountId();
@@ -43,7 +43,7 @@ public void TestSendPaymentChat()
 
             var chatMessageMap = new Dictionary<string, object>
             {
-                {ChatMessageText.FIELD_TEXT, Text}
+                {ChatMessageText.FIELD_TEXT, PaymentChatText}
             };
             ChatMessageText.Create(ApiContext, chatMessageMap, UserId, chatId);
         }
@@ -52,9 +52,9 @@ private static int CreatePaymentAndGetId()
         {
             var requestMap = new Dictionary<string, object>
             {
-                {Payment.FIELD_AMOUNT, new Amount(Amount, Currency)},
+                {Payment.FIELD_AMOUNT, new Amount(PaymentChatAmountEur, PaymentChatCurrency)},
                 {Payment.FIELD_COUNTERPARTY_ALIAS, CounterPartyAlias},
-                {Payment.FIELD_DESCRIPTION, Description},
+                {Payment.FIELD_DESCRIPTION, PaymentChatDescription},
             };
 
             return Payment.Create(ApiContext, requestMap, UserId, MonetaryAccountId).Value;

BunqSdk.Tests/Model/Generated/Endpoint/PaymentTest.cs

@@ -15,9 +15,9 @@ public class PaymentTest : BunqSdkTestBase
         /// <summary>
         /// Config values.
         /// </summary>
-        private const string Amount = "0.01";
-        private const string Currency = "EUR";
-        private const string Description = "C# test Payment";
+        private const string PaymentAmountEur = "0.01";
+        private const string PaymentCurrency = "EUR";
+        private const string PaymentDescription = "C# test Payment";
 
         private static readonly int UserId = Config.GetUserId();
         private static readonly int MonetaryAccountId = Config.GetMonetarytAccountId();
@@ -39,8 +39,8 @@ public void TestMakePaymentToOtherUser()
         {
             var requestMap = new Dictionary<string, object>
             {
-                {Payment.FIELD_AMOUNT, new Amount(Amount, Currency)},
-                {Payment.FIELD_DESCRIPTION, Description},
+                {Payment.FIELD_AMOUNT, new Amount(PaymentAmountEur, PaymentCurrency)},
+                {Payment.FIELD_DESCRIPTION, PaymentDescription},
                 {Payment.FIELD_COUNTERPARTY_ALIAS, CounterPartyOther}
             };
 
@@ -57,8 +57,8 @@ public void TestMakePaymentToOtherAccount()
         {
             var requestMap = new Dictionary<string, object>
             {
-                {Payment.FIELD_AMOUNT, new Amount(Amount, Currency)},
-                {Payment.FIELD_DESCRIPTION, Description},
+                {Payment.FIELD_AMOUNT, new Amount(PaymentAmountEur, PaymentCurrency)},
+                {Payment.FIELD_DESCRIPTION, PaymentDescription},
                 {Payment.FIELD_COUNTERPARTY_ALIAS, CounterPartySelf}
             };
 

BunqSdk.Tests/Model/Generated/Endpoint/RequestInquiryTest.cs

@@ -16,10 +16,10 @@ public class RequestInquiryTest : BunqSdkTestBase
         /// <summary>
         /// Config values.
         /// </summary>
-        private const string Amount = "0.01";
-        private const string Currency = "EUR";
-        private const string Description = "C# test Payment";
-        private const string Status = "ACCEPTED";
+        private const string RequestInquiryAmountEur = "0.01";
+        private const string RequestInquiryCurrency = "EUR";
+        private const string RequestInquiryDescription = "C# test Payment";
+        private const string RequestInquiryStatus = "ACCEPTED";
         private const int IndexFirst = 0;
 
         private static readonly int UserId = Config.GetUserId();
@@ -30,7 +30,7 @@ public class RequestInquiryTest : BunqSdkTestBase
         /// <summary>
         /// API context to use for the test API calls.
         /// </summary>
-        private static readonly ApiContext API_CONTEXT = GetApiContext();
+        private static readonly ApiContext ApiContext = GetApiContext();
 
         /// <summary>
         /// Tests sending a request from monetary account 1 to monetary account 2 and accepting this request.
@@ -40,28 +40,27 @@ public void TestRequestInquiry()
         {
             var requestMap = new Dictionary<string, object>
             {
-                {RequestInquiry.FIELD_AMOUNT_INQUIRED, new Amount(Amount, Currency)},
+                {RequestInquiry.FIELD_AMOUNT_INQUIRED, new Amount(RequestInquiryAmountEur, RequestInquiryCurrency)},
                 {RequestInquiry.FIELD_COUNTERPARTY_ALIAS, CounterSelfParty},
-                {RequestInquiry.FIELD_DESCRIPTION, Description},
+                {RequestInquiry.FIELD_DESCRIPTION, RequestInquiryDescription},
                 {RequestInquiry.FIELD_ALLOW_BUNQME, false}
             };
 
-            RequestInquiry.Create(API_CONTEXT, requestMap, UserId, MonetaryAccountId);
+            RequestInquiry.Create(ApiContext, requestMap, UserId, MonetaryAccountId);
 
-            Assert.Equal(Status, AcceptRequest());
+            Assert.Equal(RequestInquiryStatus, AcceptRequest());
         }
 
         private static string AcceptRequest()
         {
-            var requestResponseId = RequestResponse
-                .List(API_CONTEXT, UserId, SecondMonetaryAccountId).Value[IndexFirst].Id.Value;
+            var requestResponseId = RequestResponse.List(ApiContext, UserId, SecondMonetaryAccountId).Value[IndexFirst].Id.Value;
 
             var requestMap = new Dictionary<string, object>
             {
-                {RequestResponse.FIELD_STATUS, Status}
+                {RequestResponse.FIELD_STATUS, RequestInquiryStatus}
             };
 
-            return RequestResponse.Update(API_CONTEXT, requestMap, UserId, SecondMonetaryAccountId,
+            return RequestResponse.Update(ApiContext, requestMap, UserId, SecondMonetaryAccountId,
                 requestResponseId).Value.Status;
         }
     }

BunqSdk.Tests/Model/Generated/Endpoint/TabUsageSingleTest.cs

@@ -16,12 +16,12 @@ public class TabUsageSingleTest : BunqSdkTestBase
         /// <summary>
         /// Config values
         /// </summary>
-        private const string TabDescription = "Pay the tab for Java test please.";
-        private const string StatusOpen = "OPEN";
-        private const string Amount = "42.00";
-        private const string Currency = "EUR";
-        private const string TabItemDescription = "Super expensive java tea";
-        private const string StatusWaiting = "WAITING_FOR_PAYMENT";
+        private const string TabUsageSingleDescription = "Pay the tab for Java test please.";
+        private const string TabUsageSingleStatusOpen = "OPEN";
+        private const string TabAmountEur = "42.00";
+        private const string TabCurrency = "EUR";
+        private const string TabItemShopDescription = "Super expensive java tea";
+        private const string TabUsageSingleStatusWaiting = "WAITING_FOR_PAYMENT";
 
         private static readonly int UserId = Config.GetUserId();
         private static readonly int MonetaryAccountId = Config.GetMonetarytAccountId();
@@ -46,7 +46,7 @@ public void TestCreateTabAndUpdate()
 
             var updateTabMap = new Dictionary<string, object>
             {
-                {TabUsageSingle.FIELD_STATUS, StatusWaiting}
+                {TabUsageSingle.FIELD_STATUS, TabUsageSingleStatusWaiting}
             };
             TabUsageSingle.Update(ApiContext, updateTabMap, UserId, MonetaryAccountId, CashRegisterId, tabUuid);
 
@@ -62,9 +62,9 @@ private static string CreateTabAndGetUuid()
         {
             var createTabMap = new Dictionary<string, object>
             {
-                {TabUsageSingle.FIELD_DESCRIPTION, TabDescription},
-                {TabUsageSingle.FIELD_STATUS, StatusOpen},
-                {TabUsageSingle.FIELD_AMOUNT_TOTAL, new Amount(Amount, Currency)}
+                {TabUsageSingle.FIELD_DESCRIPTION, TabUsageSingleDescription},
+                {TabUsageSingle.FIELD_STATUS, TabUsageSingleStatusOpen},
+                {TabUsageSingle.FIELD_AMOUNT_TOTAL, new Amount(TabAmountEur, TabCurrency)}
             };
 
             return TabUsageSingle.Create(ApiContext, createTabMap, UserId, MonetaryAccountId,
@@ -75,8 +75,8 @@ private static void AddTabItem(string tabUuid)
         {
             var tabItemMap = new Dictionary<string, object>
             {
-                {TabItemShop.FIELD_AMOUNT, new Amount(Amount, Currency)},
-                {TabItemShop.FIELD_DESCRIPTION, TabItemDescription}
+                {TabItemShop.FIELD_AMOUNT, new Amount(TabAmountEur, TabCurrency)},
+                {TabItemShop.FIELD_DESCRIPTION, TabItemShopDescription}
             };
             TabItemShop.Create(ApiContext, tabItemMap, UserId, MonetaryAccountId, CashRegisterId, tabUuid);
         }