Skip to content

Commit 2c1d64c

Browse files
author
Kevin Hellemun
committed
Changes based on review.
1 parent 6c1f3ce commit 2c1d64c

10 files changed

+12
-19
lines changed

BunqSdk/Exception/ApiException.cs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,5 @@ public ApiException(int responseCode, string messages) : base(messages)
1313
ResponseCode = responseCode;
1414
Messages = messages;
1515
}
16-
17-
protected ApiException()
18-
{
19-
throw new System.NotImplementedException();
20-
}
2116
}
2217
}

BunqSdk/Exception/BadRequestException.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ public BadRequestException(int responseCode, string messages) : base(responseCod
66
{
77
}
88
}
9-
}
9+
}

BunqSdk/Exception/ExceptionFactory.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ namespace Bunq.Sdk.Exception
44
{
55
public class ExceptionFactory
66
{
7+
/// <summary>
8+
/// HTTP error response codes constants.
9+
/// </summary>
710
private const int HTTP_RESPONSE_CODE_BAD_REQUEST = 400;
811
private const int HTTP_RESPONSE_CODE_UNAUTHORIZED = 401;
912
private const int HTTP_RESPONSE_CODE_FORBIDDEN = 403;
@@ -17,10 +20,7 @@ public class ExceptionFactory
1720
/// </summary>
1821
private const string GLUE_ERROR_MESSAGES = "\n";
1922

20-
21-
22-
/// <param name="responseCode"></param>
23-
/// <param name="messages"></param>
23+
2424
/// <returns>The exception that belongs to this status code.</returns>
2525
public static ApiException CreateExceptionForResponse(int responseCode, IList<string> messages)
2626
{

BunqSdk/Exception/ForbiddenException.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ public ForbiddenException(int responseCode, string messages) : base(responseCode
66
{
77
}
88
}
9-
}
9+
}

BunqSdk/Exception/MethodNotAllowedException.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ public MethodNotAllowedException(int responseCode, string messages) : base(respo
66
{
77
}
88
}
9-
}
9+
}

BunqSdk/Exception/NotFoundException.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ public NotFoundException(int responseCode, string messages) : base(responseCode,
66
{
77
}
88
}
9-
}
9+
}

BunqSdk/Exception/PleaseContactBunqException.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ public PleaseContactBunqException(int responseCode, string messages) : base(resp
66
{
77
}
88
}
9-
}
9+
}

BunqSdk/Exception/ToManyRequestsException.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ public ToManyRequestsException(int responseCode, string messages) : base(respons
66
{
77
}
88
}
9-
}
9+
}

BunqSdk/Exception/UnauthorizedException.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ public UnauthorizedException(int responseCode, string messages) : base(responseC
66
{
77
}
88
}
9-
}
9+
}

BunqSdk/Exception/UnknownApiErrorException.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
using System.Collections.Generic;
2-
3-
namespace Bunq.Sdk.Exception
1+
namespace Bunq.Sdk.Exception
42
{
53
/// <summary>
64
/// Exception triggered by API requests failed on the server side.

0 commit comments

Comments
 (0)