Skip to content

Commit dee3cfa

Browse files
committed
test: ✅ update should run on step
1 parent 6e840c5 commit dee3cfa

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

test/browser/features/steps/browser-steps.rb

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -197,25 +197,30 @@
197197

198198
Then(/^on ((?:[A-Za-z]+ versions (?:>=?|<=?|==) [0-9.]+(?:, )?)+):$/) do |browser_specs, steps_to_run|
199199
spec_matcher = /^([A-Za-z]+) versions (>=?|<=?|==) ([0-9.]+)$/
200+
run_steps = false
200201

201202
browser_specs.split(", ").each do |browser_spec|
202203
browser_spec.scan(spec_matcher) do |name, operator, version|
203204
should_run_steps = $browser.name.casecmp?(name) && $browser.version.send(operator, version.to_i)
204205

205206
# make sure this step is debuggable!
206-
$logger.debug("#{$browser.name} == #{name} && v#{$browser.version} #{operator} #{version}? #{should_run_steps}")
207-
207+
$logger.debug("#{$browser.name} == #{name} && v#{$browser.version} #{operator} #{version}? #{should_run_steps}")
208+
208209
if should_run_steps
209-
steps_to_run.each_line(chomp: true) do |step_to_run|
210-
step(step_to_run)
211-
end
212-
else
213-
indent = " " * 4
214-
# e.g. "a step\nanother step\n" -> " 1) a step\n 2) another step"
215-
steps_indented = steps_to_run.each_line.map.with_index(1) { |step, i| "#{indent}#{i}) #{step.chomp}" }.join("\n")
210+
run_steps = true
211+
end
212+
end
216213

217-
$logger.info("Skipping steps on #{$browser.name} v#{$browser.version}:\n#{steps_indented}")
214+
if run_steps
215+
steps_to_run.each_line(chomp: true) do |step_to_run|
216+
step(step_to_run)
218217
end
218+
else
219+
indent = " " * 4
220+
# e.g. "a step\nanother step\n" -> " 1) a step\n 2) another step"
221+
steps_indented = steps_to_run.each_line.map.with_index(1) { |step, i| "#{indent}#{i}) #{step.chomp}" }.join("\n")
222+
223+
$logger.info("Skipping steps on #{$browser.name} v#{$browser.version}:\n#{steps_indented}")
219224
end
220225
end
221226
end

0 commit comments

Comments
 (0)