Skip to content

Commit 6661fb4

Browse files
committed
test: ✅ update should run on step
1 parent 585ccbb commit 6661fb4

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

test/browser/features/steps/browser-steps.rb

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -216,27 +216,32 @@ def check_attribute_equal_if_present(field, attribute, attr_type, expected)
216216

217217
Then(/^on ((?:[A-Za-z]+ versions (?:>=?|<=?|==) [0-9.]+(?:, )?)+):$/) do |browser_specs, steps_to_run|
218218
spec_matcher = /^([A-Za-z]+) versions (>=?|<=?|==) ([0-9.]+)$/
219+
run_steps = false
219220

220221
browser_specs.split(", ").each do |browser_spec|
221222
browser_spec.scan(spec_matcher) do |name, operator, version|
222223
should_run_steps = $browser.name.casecmp?(name) && $browser.version.send(operator, version.to_i)
223224

224225
# make sure this step is debuggable!
225-
$logger.debug("#{$browser.name} == #{name} && v#{$browser.version} #{operator} #{version}? #{should_run_steps}")
226-
226+
$logger.debug("#{$browser.name} == #{name} && v#{$browser.version} #{operator} #{version}? #{should_run_steps}")
227+
227228
if should_run_steps
228-
steps_to_run.each_line(chomp: true) do |step_to_run|
229-
step(step_to_run)
230-
end
231-
else
232-
indent = " " * 4
233-
# e.g. "a step\nanother step\n" -> " 1) a step\n 2) another step"
234-
steps_indented = steps_to_run.each_line.map.with_index(1) { |step, i| "#{indent}#{i}) #{step.chomp}" }.join("\n")
235-
236-
$logger.info("Skipping steps on #{$browser.name} v#{$browser.version}:\n#{steps_indented}")
229+
run_steps = true
237230
end
238231
end
239232
end
233+
234+
if run_steps
235+
steps_to_run.each_line(chomp: true) do |step_to_run|
236+
step(step_to_run)
237+
end
238+
else
239+
indent = " " * 4
240+
# e.g. "a step\nanother step\n" -> " 1) a step\n 2) another step"
241+
steps_indented = steps_to_run.each_line.map.with_index(1) { |step, i| "#{indent}#{i}) #{step.chomp}" }.join("\n")
242+
243+
$logger.info("Skipping steps on #{$browser.name} v#{$browser.version}:\n#{steps_indented}")
244+
end
240245
end
241246

242247
module Maze

0 commit comments

Comments
 (0)