style: remove useless ts-ignore, fix no-use-before-define

Author: bufferoverflow

package.json

@@ -105,7 +105,6 @@
     "rules": {
       "@typescript-eslint/no-var-requires": 0,
       "@typescript-eslint/ban-ts-ignore": 0,
-      "@typescript-eslint/no-use-before-define": 0,
       "@typescript-eslint/no-explicit-any": 0,
       "@typescript-eslint/explicit-function-return-type": 0,
       "@typescript-eslint/explicit-member-accessibility": 0

test/functional/lib/mock_gitlab_server.ts

@@ -17,9 +17,7 @@ export default class GitlabServer {
 
   start(port: number): Promise<any> {
     return new Promise(resolve => {
-      // @ts-ignore
       this.app.use(bodyParser.json());
-      // @ts-ignore
       this.app.use(
         bodyParser.urlencoded({
           extended: true,

test/functional/publish/index.ts

@@ -2,8 +2,6 @@ import { CREDENTIALS, PACKAGE, WRONG_CREDENTIALS } from '../config.functional';
 import { HTTP_STATUS } from '../../lib/constants';
 
 export default (server: any, gitlab: any) => {
-  // eslint-disable-line no-unused-vars
-
   describe('package publish tests', () => {
     beforeEach(() => {
       return server.auth(CREDENTIALS.user, CREDENTIALS.password);

test/lib/request.ts

@@ -7,6 +7,11 @@ import { IRequestPromise } from '../types';
 
 const requestData = Symbol('smart_request_data');
 
+function injectResponse(smartObject: any, promise: Promise<any>): Promise<any> {
+  promise[requestData] = smartObject[requestData];
+  return promise;
+}
+
 export class PromiseAssert extends Promise<any> implements IRequestPromise {
   public constructor(options: any) {
     super(options);
@@ -53,7 +58,6 @@ export class PromiseAssert extends Promise<any> implements IRequestPromise {
   }
 
   public body_error(expected: any) {
-    // $FlowFixMe
     const selfData = this[requestData];
 
     return injectResponse(
@@ -98,12 +102,6 @@ export class PromiseAssert extends Promise<any> implements IRequestPromise {
   }
 }
 
-function injectResponse(smartObject: any, promise: Promise<any>): Promise<any> {
-  // $FlowFixMe
-  promise[requestData] = smartObject[requestData];
-  return promise;
-}
-
 function smartRequest(options: any): Promise<any> {
   const smartObject: any = {};
 

test/lib/server_process.ts

@@ -54,7 +54,6 @@ export default class VerdaccioProcess implements IServerProcess {
     };
 
     if (this.isDebug) {
-      // @ts-ignore
       const debugPort = parseInt(this.config.port, 10) + 5;
 
       childOptions = Object.assign({}, childOptions, {

test/unit/partials/config/index.ts

@@ -11,9 +11,7 @@ const verdaccioGitlabConfig: VerdaccioGitlabConfig = {
 };
 
 const options: PluginOptions<VerdaccioGitlabConfig> = {
-  // @ts-ignore
   config:  {},
-  // @ts-ignore
   logger: logger
 };