Use UTF8 strings instead of Base64 bytes for InternalizeAction prefix and suffix

jchavannes · jchavannes · commit 3cc6b385af32 · 2025-09-17T10:40:57.000-07:00
diff --git a/src/wallet/substrates/WalletWireProcessor.ts b/src/wallet/substrates/WalletWireProcessor.ts
@@ -819,7 +819,7 @@ export default class WalletWireProcessor implements WalletWire {
               const derivationPrefixBytes = paramsReader.read(
                 derivationPrefixLength
               )
-              output.paymentRemittance.derivationPrefix = Utils.toBase64(
+              output.paymentRemittance.derivationPrefix = Utils.toUTF8(
                 derivationPrefixBytes
               )
 
@@ -828,7 +828,7 @@ export default class WalletWireProcessor implements WalletWire {
               const derivationSuffixBytes = paramsReader.read(
                 derivationSuffixLength
               )
-              output.paymentRemittance.derivationSuffix = Utils.toBase64(
+              output.paymentRemittance.derivationSuffix = Utils.toUTF8(
                 derivationSuffixBytes
               )
             } else if (protocolFlag === 2) {
diff --git a/src/wallet/substrates/WalletWireTransceiver.ts b/src/wallet/substrates/WalletWireTransceiver.ts
@@ -843,13 +843,13 @@ export default class WalletWireTransceiver implements WalletInterface {
         )
         const derivationPrefixAsArray = Utils.toArray(
           out.paymentRemittance.derivationPrefix,
-          'base64'
+          'utf8'
         )
         paramWriter.writeVarIntNum(derivationPrefixAsArray.length)
         paramWriter.write(derivationPrefixAsArray)
         const derivationSuffixAsArray = Utils.toArray(
           out.paymentRemittance.derivationSuffix,
-          'base64'
+          'utf8'
         )
         paramWriter.writeVarIntNum(derivationSuffixAsArray.length)
         paramWriter.write(derivationSuffixAsArray)

Original file line number	Diff line number	Diff line change
`@@ -819,7 +819,7 @@ export default class WalletWireProcessor implements WalletWire {`
`819`	`819`	`const derivationPrefixBytes = paramsReader.read(`
`820`	`820`	`derivationPrefixLength`
`821`	`821`	`)`
`822`		`- output.paymentRemittance.derivationPrefix = Utils.toBase64(`
	`822`	`+ output.paymentRemittance.derivationPrefix = Utils.toUTF8(`
`823`	`823`	`derivationPrefixBytes`
`824`	`824`	`)`
`825`	`825`
`@@ -828,7 +828,7 @@ export default class WalletWireProcessor implements WalletWire {`
`828`	`828`	`const derivationSuffixBytes = paramsReader.read(`
`829`	`829`	`derivationSuffixLength`
`830`	`830`	`)`
`831`		`- output.paymentRemittance.derivationSuffix = Utils.toBase64(`
	`831`	`+ output.paymentRemittance.derivationSuffix = Utils.toUTF8(`
`832`	`832`	`derivationSuffixBytes`
`833`	`833`	`)`
`834`	`834`	`} else if (protocolFlag === 2) {`
Original file line number	Diff line number	Diff line change
`@@ -843,13 +843,13 @@ export default class WalletWireTransceiver implements WalletInterface {`
`843`	`843`	`)`
`844`	`844`	`const derivationPrefixAsArray = Utils.toArray(`
`845`	`845`	`out.paymentRemittance.derivationPrefix,`
`846`		`- 'base64'`
	`846`	`+ 'utf8'`
`847`	`847`	`)`
`848`	`848`	`paramWriter.writeVarIntNum(derivationPrefixAsArray.length)`
`849`	`849`	`paramWriter.write(derivationPrefixAsArray)`
`850`	`850`	`const derivationSuffixAsArray = Utils.toArray(`
`851`	`851`	`out.paymentRemittance.derivationSuffix,`
`852`		`- 'base64'`
	`852`	`+ 'utf8'`
`853`	`853`	`)`
`854`	`854`	`paramWriter.writeVarIntNum(derivationSuffixAsArray.length)`
`855`	`855`	`paramWriter.write(derivationSuffixAsArray)`