Avoid process.exit, throw and catch errors

Author: vedharish

lib/config.js

@@ -14,7 +14,7 @@ var formatPath = function(path) {
   }
   if (!fs.existsSync(path) && !fs.existsSync(path.split('?')[0])) {
     console.error('Test path: ' + path + ' is invalid.');
-    process.exit(1);
+    throw new Error('Test path: ' + path + ' is invalid.');
   }
   return path;
 };
@@ -30,12 +30,13 @@ exports.config = function(config_path) {
   } catch (e) {
     if (e.code === 'MODULE_NOT_FOUND') {
       logger.info('Configuration file `browserstack.json` is missing.');
+      throw new Error('Configuration file `browserstack.json` is missing.');
     } else {
       logger.info('Invalid configuration in `browserstack.json` file');
       logger.info(e.message);
       logger.info(e.stack);
+      throw new Error('Invalid configuration in `browserstack.json` file');
     }
-    process.exit(1);
   }
 
   var package_json = {};
@@ -79,7 +80,7 @@ exports.config = function(config_path) {
   ['username', 'key', 'browsers', 'test_path'].forEach(function(param) {
     if (typeof config[param] === 'undefined' && typeof that[param] === 'undefined') {
       console.error('Configuration parameter `%s` is required.', param);
-      process.exit(1);
+      throw new Error('Configuration parameter `%s` is required.', param);
     }
   });
 

lib/configParser.js

@@ -13,7 +13,7 @@ var ConfigParser = {
       if(error) {
         logger.info('Error getting browsers list from BrowserStack');
         logger.info(error);
-        process.exit(1);
+        throw new Error('Error getting browsers list from BrowserStack');
       }
       ConfigParser.bsBrowsers = browsers;
       for (var key in browser_config) {

lib/local.js

@@ -24,7 +24,7 @@ var Tunnel = function Tunnel(key, port, uniqueIdentifier, config, callback) {
       if (stdout.indexOf('Error') >= 0 || error) {
         logger.debug('[%s] Tunnel launching failed', new Date());
         logger.debug(stdout);
-        process.exit('SIGINT');
+        throw new Error('[%s] Tunnel launching failed', new Date());
       }
     });
 
@@ -35,7 +35,7 @@ var Tunnel = function Tunnel(key, port, uniqueIdentifier, config, callback) {
     setTimeout(function() {
       if (!running) {
         logger.error('BrowserStackLocal failed to launch within 30 seconds.');
-        process.exit(1);
+        throw new Error('BrowserStackLocal failed to launch within 30 seconds.');
       }
     }, 30 * 1000);
 
@@ -181,7 +181,7 @@ var Tunnel = function Tunnel(key, port, uniqueIdentifier, config, callback) {
         }, 100);
       }).on('error', function(e) {
         logger.info('Got error while downloading binary: ' + e.message);
-        process.exit('SIGINT');
+        throw new Error('Got error while downloading binary: ' + e.message);
       });
     });
   });

lib/server.js

@@ -313,7 +313,6 @@ exports.Server = function Server(bsClient, workers, config, callback) {
 
             logger.trace('[%s] _report: checkAndTerminateWorker: all tests done', worker.id, config.status && 'with failures');
             callback(null, 'All Tests Done');
-            //process.exit('SIGTERM');
           }
         });
       });

package.json

@@ -1,7 +1,7 @@
 {
   "name": "browserstack-runner",
   "description": "A command line interface to run browser tests over BrowserStack",
-  "version": "0.4.5",
+  "version": "0.4.4",
   "homepage": "https://github.com/browserstack/browserstack-runner",
   "repository": {
     "type": "git",