Tests added for CLI

Author: pankaj-a

bin/runner.js

@@ -69,11 +69,11 @@ try {
 }
 
 // extract a path to file to store tunnel pid
-if(yargs['pid']) {
-  if(yargs['pid'].length > 0) {
-    config.tunnel_pid_file = yargs['pid'];
+if(yargs.hasOwnProperty('pid')) {
+  if(yargs['pid'].trim().length > 0) {
+    config.tunnel_pid_file = yargs['pid'].trim();
   } else {
-    console.error('Error while parsing flag --pid. Usage: --pid=/path/to/file');
+    throw new Error('Empty pid file path');
   }
 }
 
@@ -84,7 +84,13 @@ if(yargs['browsers']) {
       return yargs['browsers'].indexOf(browser['cli_key']) !== -1;
     });
   } else {
-    console.error('No browser keys specified. Usage --browsers <key1> <key2> ...');
+    throw new Error('No browser keys specified. Usage --browsers <key1> <key2> ...');
+  }
+  if(config.browsers.length === 0) {
+    throw new Error('Invalid browser keys');
+  }
+  if(config.browsers.length < yargs['browsers'].length) {
+    console.warn('Some browser keys not present in config file.');
   }
 }
 

tests/behaviour/runner.js

@@ -7,7 +7,9 @@ var assert = require('assert'),
   path = require('path'),
   http = require('http'),
   browserstackRunner = require('../../bin/cli.js'),
-  Tunnel = require('../../lib/local.js').Tunnel;
+  Tunnel = require('../../lib/local.js').Tunnel,
+  exec = require('child_process').exec,
+  execSync = require('child_process').execSync;
 
 var getBaseConfig = function() {
   return { 
@@ -219,3 +221,39 @@ describe('Pass/Fail reporting', function() {
     });
   });
 });
+
+describe('Command Line Interface Tests', function() {
+  this.timeout(0);
+  it('Should run with valid CLI arguments', function(done) {
+    execSync('bin/runner.js init');
+    exec('bin/runner.js --browsers 1 --path tests/behaviour/resources/qunit_sample.html', null, function(error, stdout, stderr) {
+      assert.equal(error, null);
+      done();
+    });
+  });
+  it('Should raise errors if all invalid browser keys.', function(done) {
+    exec('bin/runner.js --browsers 10 --path tests/behaviour/resources/qunit_sample.html', null, function(error, stdout, stderr) {
+      assert.notEqual(error.message.match('Invalid'), null);
+      done();
+    });
+  });
+  it('Should raise error if invalid test path', function(done) {
+    exec('bin/runner.js --browsers 1 --path invalid/path', function(error, stdout, stderr) {
+    assert.notEqual(error, null);
+    assert.notEqual(error.message.match('Invalid'), null);
+      done();
+    });
+  });
+  it('Should run tests on browsers present if some keys not present', function(done) {
+    exec('bin/runner.js --browsers 1 10 --path tests/behaviour/resources/qunit_sample.html', null, function(error, stdout, stderr) {
+      assert.equal(error, null);
+      done();
+    });
+  });
+  it('Should raise error if empty pid path with pid parameter', function(done) {
+    exec('bin/runner.js --browsers 1 --path tests/behaviour/resources/qunit_sample.html --pid', null, function(error, stdout, stderr) {
+      assert.notEqual(error, null);
+      done();
+    });
+  });
+});