Testing: run also tests for mocha v2.4.5

Author: flore77

tests/external-tests.js

@@ -13,6 +13,47 @@ var runnerPath = path.resolve(path.join(__dirname, '..', 'bin', 'cli.js'));
 var testHome = path.resolve(__dirname);
 process.chdir(testHome);
 
+/**
+ * Mocha v2.4.5 - to change with another Mocha version or
+ * something with Mocha tests
+ *
+ * index.html - 22 tests, 18 passed, 4 failed -> one test is displayed twice,
+ *  so they are displayed 5 failing tests, but counted only 4
+ * large.html - 64 tests, 60 passed, 4 failed -> only 2 tests are failing, but
+ *  they are displayed twice
+ * opts.html - 8 tests, 2 passed, 6 failed -> only 3 tests are failing, but
+ *  they are displayed twice
+ *
+ * By "displayed" it is referred the Mocha HTML Reporter.
+ *
+ * From the above explanations it is clear that there are some inconsistencies,
+ * also because Mocha's HTML Reporter counted number of tests does not match
+ * the number of displyed tests.
+ *
+ * The cause is (snippet from Mocha's HTML reporter):
+ *
+ * runner.on('fail', function(test) {
+ *  // For type = 'test' its possible that the test failed due to multiple
+ *  // done() calls. So report the issue here.
+ *  if (test.type === 'hook'
+ *    || test.type === 'test') {
+ *    runner.emit('test end', test);
+ *  }
+ * });
+ *
+ * This is why failed tests are displayed twice...
+ *
+ * The JsReporters is counting the tests on the "test end" event, that's why
+ * it is capturing the failing tests twice, in the "index.html" it does not
+ * capture everything, because there is an async test, which failure is
+ * triggered after a timeout and the JsReporters is not waiting, because
+ * it cannot know how much to wait.
+ *
+ *
+ * This been said, the JsReporter MochaAdapter is functioning well, this
+ * version of Mocha is not reliable and should be changed.
+ */
+
 var repositories = [
   {
     name: 'qunit',
@@ -36,7 +77,7 @@ var repositories = [
       failed: 0
     }
   },
-  /*{
+  {
     name: 'mocha',
     tag: 'v2.4.5',
     url: 'https://github.com/mochajs/mocha.git',
@@ -55,11 +96,11 @@ var repositories = [
       'test/browser/opts.html'
     ],
     expected_results: {
-      tests: 89,
+      tests: 94,
       passed: 80,
-      failed: 9
+      failed: 14
     }
-  },*/
+  },
   {
     name: 'spine',
     tag: 'v.1.6.2',