Make download logic os independant

Author: 07souravkunda

lib/LocalBinary.js

@@ -65,57 +65,31 @@ function LocalBinary(){
     var destBinaryName = (this.windows) ? 'BrowserStackLocal.exe' : 'BrowserStackLocal';
     var binaryPath = path.join(destParentDir, destBinaryName);
 
-    var options = url.parse(this.httpPath);
-    if(conf.proxyHost && conf.proxyPort) {
-      options.agent = new HttpsProxyAgent({
-        host: conf.proxyHost,
-        port: conf.proxyPort
-      });
-    }
-
-    const osPlatform = os.platform();
-    const osVersion = parseInt(os.release());
-
     let cmd, opts;
-
-    if(osPlatform.includes('win') && osVersion < 10) {
-      cmd = 'wget';
-      opts = [];
-      if(conf.proxyHost && conf.proxyPort) {
-        opts.push('-e', `https_proxy=${conf.proxyHost}:${conf.proxyPort}`, '--no-check-certificate');
-      }
-      opts.push('-O', binaryPath, options.href);
-    }else{
-      cmd = 'curl';
-      opts = ['-o', binaryPath, options.href];
-
-      if(conf.proxyHost && conf.proxyPort) {
-        opts.push('--proxy', `${conf.proxyHost}:${conf.proxyPort}`);
-      }
+    cmd = 'node';
+    opts = [path.join(__dirname, 'download.js'), binaryPath, this.httpPath]
+    if(conf.proxyHost && conf.proxyPort) {
+      opts.push(conf.proxyHost, conf.proxyPort);
     }
 
     try{
       const obj = childProcess.spawnSync(cmd, opts);
       let output;
       if(obj.stdout.length > 0) {
-        output = Buffer.from(JSON.parse(JSON.stringify(obj.stderr)).data).toString();
-      } else if(obj.stderr.length > 0) {
-        output = Buffer.from(JSON.parse(JSON.stringify(obj.stderr)).data).toString();
-      }
-      if(output.includes('failed')){
-        console.log('failed to download');
-        return that.retryBinaryDownload(conf, destParentDir, null, retries, binaryPath);
-      }else{
         if(fs.existsSync(binaryPath)){
           fs.chmodSync(binaryPath, '0755');
           return binaryPath;
         }else{
           console.log('failed to download');
           return that.retryBinaryDownload(conf, destParentDir, null, retries, binaryPath);
         }
+      } else if(obj.stderr.length > 0) {
+        output = Buffer.from(JSON.parse(JSON.stringify(obj.stderr)).data).toString();
+        console.error(output)
+        return that.retryBinaryDownload(conf, destParentDir, null, retries, binaryPath);
       }
     } catch(err) {
-      console.log('Download failed with error', err);
+      console.error('Download failed with error', err);
       return that.retryBinaryDownload(conf, destParentDir, null, retries, binaryPath);
     }
   };

lib/download.js

@@ -0,0 +1,32 @@
+const https = require('https'),
+      fs = require('fs'),
+      path = require('path'),
+      HttpsProxyAgent = require('https-proxy-agent'),
+      url = require('url');
+
+const binaryPath = process.argv[2],httpPath = process.argv[3], proxyHost = process.argv[4], proxyPort = process.argv[5];
+
+var fileStream = fs.createWriteStream(binaryPath);
+
+var options = url.parse(httpPath);
+if(proxyHost && proxyPort) {
+  options.agent = new HttpsProxyAgent({
+    host: proxyHost,
+    port: proxyPort
+  });
+}
+
+https.get(options, function (response) {
+  response.pipe(fileStream);
+  response.on('error', function(err) {
+    console.error('Got Error in binary download response', err);
+  });
+  fileStream.on('error', function (err) {
+    console.error('Got Error while downloading binary file', err);
+  });
+  fileStream.on('close', function () {
+    console.log('Done');
+  });
+}).on('error', function(err) {
+  console.error('Got Error in binary downloading request', err);
+});