Add retries on error

Author: vedharish

lib/Local.js

@@ -1,4 +1,5 @@
 var childProcess = require('child_process'),
+  fs = require('fs'),
   path = require('path'),
   running = require('is-running'),
   LocalBinary = require('./LocalBinary'),
@@ -7,16 +8,17 @@ var childProcess = require('child_process'),
 
 function Local(){
   this.pid = undefined;
+  this.retriesLeft = 5;
   this.key = process.env.BROWSERSTACK_ACCESS_KEY;
   this.logfile = path.join(process.cwd(), 'local.log');
   this.opcode = 'start';
   this.exitCallback;
-  this.userArgs = [];
 
   this.errorRegex = /\*\*\* Error: [^\r\n]*/i;
   this.doneRegex = /Press Ctrl-C to exit/i;
 
   this.start = function(options, callback){
+    this.userArgs = [];
     var that = this;
     this.addArgs(options);
 
@@ -29,7 +31,19 @@ function Local(){
 
       that.opcode = 'start';
       that.tunnel = childProcess.execFile(that.binaryPath, that.getBinaryArgs(), function(error, stdout, stderr){
-        if(error) callback(new LocalError(error.toString()));
+        if(error) {
+          console.error('Error while trying to execute binary', error);
+          if(that.retriesLeft > 0) {
+            console.log('Retrying Binary Download. Retries Left', that.retriesLeft);
+            that.retriesLeft -= 1;
+            fs.unlinkSync(that.binaryPath);
+            delete(that.binaryPath);
+            that.start(options, callback);
+            return;
+          } else {
+            callback(new LocalError(error.toString()));
+          }
+        }
 
         var data = {};
         if(stdout)
@@ -206,6 +220,7 @@ function Local(){
       }
       this.binary.binaryPath(conf, callback);
     } else {
+      console.log('BINARY PATH IS DEFINED');
       callback(this.binaryPath);
     }
   };

lib/LocalBinary.js

@@ -22,7 +22,23 @@ function LocalBinary(){
       this.httpPath = 'https://s3.amazonaws.com/browserStack/browserstack-local/BrowserStackLocal-linux-ia32';
   }
 
-  this.download = function(conf, destParentDir, callback){
+  this.retryBinaryDownload = function(conf, destParentDir, callback, retries, binaryPath) {
+    var that = this;
+    if(retries > 0) {
+      console.log('Retrying Download. Retries left', retries);
+      fs.stat(binaryPath, function(err) {
+        if(err == null) {
+          fs.unlinkSync(binaryPath);
+        }
+        that.download(conf, destParentDir, callback, retries - 1);
+      });
+    } else {
+      console.error('Number of retries to download exceeded.');
+    }
+  };
+
+  this.download = function(conf, destParentDir, callback, retries){
+    var that = this;
     if(!this.checkPath(destParentDir))
       fs.mkdirSync(destParentDir);
 
@@ -31,7 +47,7 @@ function LocalBinary(){
     var fileStream = fs.createWriteStream(binaryPath);
 
     var options = url.parse(this.httpPath);
-    if(conf.proxyHost && conf.proxyPort){
+    if(conf.proxyHost && conf.proxyPort) {
       options.agent = new HttpsProxyAgent({
         host: conf.proxyHost,
         port: conf.proxyPort
@@ -40,14 +56,22 @@ function LocalBinary(){
 
     https.get(options, function (response) {
       response.pipe(fileStream);
+      response.on('error', function(err) {
+        console.error('Got Error in binary download response', err);
+        that.retryBinaryDownload(conf, destParentDir, callback, retries, binaryPath);
+      });
       fileStream.on('error', function (err) {
         console.error('Got Error while downloading binary file', err);
+        that.retryBinaryDownload(conf, destParentDir, callback, retries, binaryPath);
       });
       fileStream.on('close', function () {
         fs.chmod(binaryPath, '0755', function() {
           callback(binaryPath);
         });
       });
+    }).on('error', function(err) {
+      console.error('Got Error in binary downloading request', err);
+      that.retryBinaryDownload(conf, destParentDir, callback, retries, binaryPath);
     });
   };
 
@@ -58,7 +82,7 @@ function LocalBinary(){
     if(this.checkPath(binaryPath, fs.X_OK)){
       callback(binaryPath);
     } else {
-      this.download(conf, destParentDir, callback);
+      this.download(conf, destParentDir, callback, 5);
     }
   };