return only in sync case

Author: 07souravkunda

lib/Local.js

@@ -245,10 +245,16 @@ function Local(){
         conf.proxyHost = this.proxyHost;
         conf.proxyPort = this.proxyPort;
       }
-      return callback ? this.binary.binaryPath(conf, callback) : this.binary.binaryPath(conf);
+      if(!callback) {
+        return this.binary.binaryPath(conf);
+      }
+      this.binary.binaryPath(conf, callback);
     } else {
       console.log('BINARY PATH IS DEFINED');
-      return callback ? callback(this.binaryPath) : this.binaryPath;
+      if(!callback) {
+        return this.binaryPath;
+      }
+      callback(this.binaryPath);
     }
   };
 

lib/LocalBinary.js

@@ -49,7 +49,10 @@ function LocalBinary(){
         if(err == null) {
           fs.unlinkSync(binaryPath);
         }
-        return callback ? that.download(conf, destParentDir, callback, retries - 1) : that.downloadSync(conf, destParentDir, retries - 1);
+        if(!callback) {
+          return that.downloadSync(conf, destParentDir, retries - 1);
+        }
+        that.download(conf, destParentDir, callback, retries - 1);
       });
     } else {
       console.error('Number of retries to download exceeded.');
@@ -137,9 +140,15 @@ function LocalBinary(){
     var destBinaryName = (this.windows) ? 'BrowserStackLocal.exe' : 'BrowserStackLocal';
     var binaryPath = path.join(destParentDir, destBinaryName);
     if(this.checkPath(binaryPath, fs.X_OK)){
-      return callback ? callback(binaryPath) : binaryPath;
+      if(!callback) {
+        return binaryPath;
+      }
+      callback(binaryPath);
     } else {
-      return callback ? this.download(conf, destParentDir, callback, 5) : this.downloadSync(conf, destParentDir, 5);
+      if(!callback) {
+        return this.downloadSync(conf, destParentDir, 5);
+      }
+      this.download(conf, destParentDir, callback, 5);
     }
   };