PR Review Changes

Author: amaanbs

lib/Local.js

@@ -1,6 +1,7 @@
 var childProcess = require('child_process'),
   os = require('os'),
   fs = require('fs'),
+  util = require('util'),
   path = require('path'),
   running = require('is-running'),
   LocalBinary = require('./LocalBinary'),
@@ -59,7 +60,7 @@ function Local(){
         return;
       }
     }catch(error){
-      const binaryDownloadErrorMessage = `Error while trying to execute binary: ${error}`;
+      const binaryDownloadErrorMessage = `Error while trying to execute binary: ${util.format(error)}`;
       console.error(binaryDownloadErrorMessage);
       if(that.retriesLeft > 0) {
         console.log('Retrying Binary Download. Retries Left', that.retriesLeft);
@@ -90,7 +91,7 @@ function Local(){
       that.opcode = 'start';
       that.tunnel = childProcess.execFile(that.binaryPath, that.getBinaryArgs(), function(error, stdout, stderr){
         if(error) {
-          const binaryDownloadErrorMessage = `Error while trying to execute binary: ${error}`;
+          const binaryDownloadErrorMessage = `Error while trying to execute binary: ${util.format(error)}`;
           console.error(binaryDownloadErrorMessage);
           if(that.retriesLeft > 0) {
             console.log('Retrying Binary Download. Retries Left', that.retriesLeft);

lib/LocalBinary.js

@@ -3,6 +3,7 @@ var https = require('https'),
   fs = require('fs'),
   path = require('path'),
   os = require('os'),
+  util = require('util'),
   childProcess = require('child_process'),
   zlib = require('zlib'),
   HttpsProxyAgent = require('https-proxy-agent'),
@@ -19,7 +20,7 @@ function LocalBinary(){
   this.downloadErrorMessage = null;
 
   this.getSourceUrl = function(conf, retries) {
-    /* Request for an endpoint from Rails no more than twice with 5 retries each */
+    /* Request for an endpoint to download the local binary from Rails no more than twice with 5 retries each */
     if (![4, 9].includes(retries) && this.sourceURL != null) {
       return this.sourceURL;
     }
@@ -158,7 +159,7 @@ function LocalBinary(){
         return that.retryBinaryDownload(conf, destParentDir, null, retries, binaryPath);
       }
     } catch(err) {
-      that.binaryDownloadError('Download failed with error', err.getMessage());
+      that.binaryDownloadError('Download failed with error', util.format(err));
       return that.retryBinaryDownload(conf, destParentDir, null, retries, binaryPath);
     }
   };
@@ -211,11 +212,11 @@ function LocalBinary(){
       }
 
       response.on('error', function(err) {
-        that.binaryDownloadError('Got Error in binary download response', err.message);
+        that.binaryDownloadError('Got Error in binary download response', util.format(err));
         that.retryBinaryDownload(conf, destParentDir, callback, retries, binaryPath);
       });
       fileStream.on('error', function (err) {
-        that.binaryDownloadError('Got Error while downloading binary file', err.message);
+        that.binaryDownloadError('Got Error while downloading binary file', util.format(err));
         that.retryBinaryDownload(conf, destParentDir, callback, retries, binaryPath);
       });
       fileStream.on('close', function () {
@@ -224,7 +225,7 @@ function LocalBinary(){
         });
       });
     }).on('error', function(err) {
-      that.binaryDownloadError('Got Error in binary downloading request', err.message);
+      that.binaryDownloadError('Got Error in binary downloading request', util.format(err));
       that.retryBinaryDownload(conf, destParentDir, callback, retries, binaryPath);
     });
   };

lib/fetchDownloadSourceUrl.js

@@ -6,8 +6,7 @@ const authToken = process.argv[2], proxyHost = process.argv[5], proxyPort = proc
 
 let body = '', data = {'auth_token': authToken};
 const options = {
-  // hostname: 'local.browserstack.com',
-  hostname: 'k8s-devlocal.bsstag.com',
+  hostname: 'local.browserstack.com',
   port: 443,
   path: '/binary/api/v1/endpoint',
   method: 'POST',