remove comments and update test case

Author: pranavj1001

bin/helpers/capabilityHelper.js

@@ -133,11 +133,8 @@ const caps = (bsConfig, zip) => {
 const addCypressZipStartLocation = (runSettings) => {
   let resolvedHomeDirectoryPath = path.resolve(runSettings.home_directory);
   let resolvedCypressConfigFilePath = path.resolve(runSettings.cypressConfigFilePath);
-  // For example
-  // resolvedHomeDirectoryPath -> '/Users/<user_name>/path'
-  // resolvedCypressConfigFilePath -> '/Users/<user_name>/path/cypress.json' or '/Users/<user_name>/path/more_path/cypress.json'
-  runSettings.cypressZipStartLocation = path.dirname(resolvedCypressConfigFilePath.split(resolvedHomeDirectoryPath)[1]); // cypressZipStartLocation -> '/' or '/more_path'
-  runSettings.cypressZipStartLocation = runSettings.cypressZipStartLocation.substring(1); // cypressZipStartLocation -> '' or 'more_path'
+  runSettings.cypressZipStartLocation = path.dirname(resolvedCypressConfigFilePath.split(resolvedHomeDirectoryPath)[1]);
+  runSettings.cypressZipStartLocation = runSettings.cypressZipStartLocation.substring(1);
 }
 
 const validate = (bsConfig, args) => {

test/unit/bin/helpers/capabilityHelper.js

@@ -1085,7 +1085,6 @@ describe("capabilityHelper.js", () => {
       });
 
       it("does not exist", () => {
-        // sinon.stub(fs, 'existsSync').returns(false);
         bsConfig.run_settings.cypressConfigFilePath = 'false';
         bsConfig.run_settings.cypress_config_filename = 'false';
         bsConfig.run_settings.home_directory = '/some/random';
@@ -1107,7 +1106,6 @@ describe("capabilityHelper.js", () => {
       });
 
       it("is not a directory", () => {
-        // sinon.stub(fs, 'existsSync').returns(false);
         bsConfig.run_settings.cypressConfigFilePath = 'false';
         bsConfig.run_settings.cypress_config_filename = 'false';
         bsConfig.run_settings.home_directory = '/some/random/file.ext';
@@ -1131,7 +1129,6 @@ describe("capabilityHelper.js", () => {
       });
 
       it("does not contain cypressConfigFilePath", () => {
-        // sinon.stub(fs, 'existsSync').returns(false);
         bsConfig.run_settings.cypressConfigFilePath = 'false';
         bsConfig.run_settings.cypress_config_filename = 'false';
         bsConfig.run_settings.home_directory = '/some/random';
@@ -1153,6 +1150,29 @@ describe("capabilityHelper.js", () => {
             fs.statSync.restore();
           });
       });
+
+      it("does not contain cypressConfigFilePath with special chars", () => {
+        bsConfig.run_settings.cypressConfigFilePath = 'false';
+        bsConfig.run_settings.cypress_config_filename = 'false';
+        bsConfig.run_settings.home_directory = '/$some!@#$%^&*()_+=-[]{};:<>?\'\\\//random';
+
+        sinon.stub(fs, 'existsSync').returns(true);
+        sinon.stub(fs, 'statSync').returns({ isDirectory: () => true });
+        
+        return capabilityHelper
+        .validate(bsConfig, {})
+        .then(function (data) {
+          chai.assert.fail("Promise error");
+        })
+        .catch((error) => {
+          chai.assert.equal(
+            error,
+            Constants.validationMessages.CYPRESS_CONFIG_FILE_NOT_PART_OF_HOME_DIRECTORY
+            );
+            fs.existsSync.restore();
+            fs.statSync.restore();
+          });
+      });
     });
   });
 });