fix: use unzipper as fallback for decompress

Author: asambstack

bin/helpers/buildArtifacts.js

@@ -10,7 +10,7 @@ const logger = require('./logger').winstonLogger,
 
 const request = require('request');
 const decompress = require('decompress');
-
+const unzipper = require("unzipper");
 
 let BUILD_ARTIFACTS_TOTAL_COUNT = 0;
 let BUILD_ARTIFACTS_FAIL_COUNT = 0;
@@ -136,13 +136,25 @@ const downloadAndUnzip = async (filePath, fileName, url) => {
 
 const unzipFile = async (filePath, fileName) => {
   return new Promise( async (resolve, reject) => {
-    await decompress(path.join(filePath, fileName), filePath)
-    .then((files) => {
+    try {
+      await decompress(path.join(filePath, fileName), filePath)
       resolve();
-    })
-    .catch((error) => {
-      reject(error);
-    });
+    } catch (error) {
+      logger.debug(`Error unzipping with decompress: ${error}, trying with unzipper.`);
+      try {
+        fs.createReadStream(path.join(filePath, fileName))
+          .pipe(unzipper.Extract({ path: filePath }))
+          .on("close", () => {
+            resolve();
+          })
+          .on("error", (err) => {
+            reject(err);
+          });
+      } catch (unzipperError) {
+        logger.debug(`Unzip unsuccessful with unzipper`);
+      }
+      reject(Constants.debugMessages.BUILD_ARTIFACTS_UNZIP_FAILURE);
+    }
   });
 }
 

bin/helpers/constants.js

@@ -271,6 +271,10 @@ const cliMessages = {
   },
 };
 
+const debugMessages = {
+  BUILD_ARTIFACTS_UNZIP_FAILURE: "Failed to unzip build artifacts",
+};
+
 const messageTypes = {
   SUCCESS: "success",
   ERROR: "error",
@@ -455,6 +459,7 @@ module.exports = Object.freeze({
   syncCLI,
   userMessages,
   cliMessages,
+  debugMessages,
   validationMessages,
   messageTypes,
   allowedFileTypes,

package.json

@@ -34,7 +34,8 @@
     "windows-release": "^5.1.0",
     "winston": "2.4.4",
     "yargs": "14.2.3",
-    "decompress": "4.2.1"
+    "decompress": "4.2.1",
+    "unzipper": "^0.12.3"
   },
   "repository": {
     "type": "git",