refactor

Author: nagpalkaran95

bin/commands/runs.js

@@ -17,11 +17,7 @@ module.exports = function run(args) {
   return utils.validateBstackJson(bsConfigPath).then(function (bsConfig) {
     utils.setUsageReportingFlag(bsConfig, args.disableUsageReporting);
 
-    // setting setDefaultAuthHash to {} if not present and set via env variables or via args.
-    utils.setDefaultAuthHash(bsConfig,args);
-
-    // setting npm_dependencies to {} if not present
-    utils.setDefaultNpmHash(bsConfig);
+    utils.setDefaults(bsConfig, args);
 
     // accept the username from command line or env variable if provided
     utils.setUsername(bsConfig, args);

bin/helpers/utils.js

@@ -115,18 +115,14 @@ exports.setParallels = (bsConfig, args) => {
   }
 };
 
-exports.setDefaultAuthHash = (bsConfig, args) => {
-  if (
-    this.isUndefined(bsConfig['auth']) &&
-    (!this.isUndefined(args.username) ||
-      !this.isUndefined(process.env.BROWSERSTACK_USERNAME))
-  ) {
+exports.setDefaults = (bsConfig, args) => {
+  // setting setDefaultAuthHash to {} if not present and set via env variables or via args.
+  if (this.isUndefined(bsConfig['auth']) && (!this.isUndefined(args.username) || !this.isUndefined(process.env.BROWSERSTACK_USERNAME))) {
     bsConfig['auth'] = {};
   }
-}
 
-exports.setDefaultNpmHash = (bsConfig) => {
-  if (bsConfig.run_settings && !bsConfig.run_settings.npm_dependencies) {
+  // setting npm_dependencies to {} if not present
+  if (bsConfig.run_settings && this.isUndefined(bsConfig.run_settings.npm_dependencies)) {
     bsConfig.run_settings.npm_dependencies = {}
   }
 }