Adding specs for config options

Author: karanshah-browserstack

test/unit/bin/commands/runs.js

@@ -5,9 +5,7 @@ const chai = require("chai"),
 const Constants = require("../../../../bin/helpers/constants"),
   logger = require("../../../../bin/helpers/logger").winstonLogger,
   testObjects = require("../../support/fixtures/testObjects");
-const { initTimeComponents, markBlockStart, markBlockEnd } = require("../../../../bin/helpers/timeComponents");
-const { setHeaded, setupLocalTesting, stopLocalBinary, setUserSpecs, setLocalConfigFile } = require("../../../../bin/helpers/utils");
-
+ 
 const proxyquire = require("proxyquire").noCallThru();
 
 chai.use(chaiAsPromised);
@@ -108,6 +106,8 @@ describe("runs", () => {
       setDefaultsStub = sandbox.stub();
       setLocalModeStub = sandbox.stub();
       setLocalConfigFileStub = sandbox.stub();
+      setBrowsersStub = sandbox.stub();
+      setConfigStub = sandbox.stub();
     });
 
     afterEach(() => {
@@ -143,7 +143,9 @@ describe("runs", () => {
           isJSONInvalid: isJSONInvalidStub,
           setLocalMode: setLocalModeStub,
           setLocalConfigFile: setLocalConfigFileStub,
-          setSystemEnvs: setSystemEnvsStub
+          setSystemEnvs: setSystemEnvsStub,
+          setBrowsers: setBrowsersStub,
+          setConfig: setConfigStub
         },
         '../helpers/capabilityHelper': {
           validate: capabilityValidatorStub
@@ -176,6 +178,7 @@ describe("runs", () => {
           sinon.assert.calledOnce(setLocalConfigFileStub);
           sinon.assert.calledOnce(setHeadedStub);
           sinon.assert.calledOnce(setNoWrapStub);
+          sinon.assert.calledOnce(setConfigStub);
           sinon.assert.calledOnce(capabilityValidatorStub);
           sinon.assert.calledOnce(getErrorCodeFromMsgStub);
           sinon.assert.calledOnce(setLocalIdentifierStub);
@@ -226,6 +229,8 @@ describe("runs", () => {
       getNumberOfSpecFilesStub = sandbox.stub().returns([]);
       setDefaultsStub = sandbox.stub();
       setLocalConfigFileStub = sandbox.stub();
+      setBrowsersStub = sandbox.stub();
+      setConfigStub = sandbox.stub();
     });
 
     afterEach(() => {
@@ -262,7 +267,9 @@ describe("runs", () => {
           setDefaults: setDefaultsStub,
           getNumberOfSpecFiles: getNumberOfSpecFilesStub,
           setLocalConfigFile: setLocalConfigFileStub,
-          setSystemEnvs: setSystemEnvsStub
+          setSystemEnvs: setSystemEnvsStub,
+          setBrowsers: setBrowsersStub,
+          setConfig: setConfigStub
         },
         '../helpers/capabilityHelper': {
           validate: capabilityValidatorStub,
@@ -359,6 +366,8 @@ describe("runs", () => {
       getNumberOfSpecFilesStub = sandbox.stub().returns([]);
       setDefaultsStub = sandbox.stub();
       setLocalConfigFileStub = sandbox.stub();
+      setConfigStub = sandbox.stub();
+      setBrowsersStub = sandbox.stub();
     });
 
     afterEach(() => {
@@ -395,7 +404,9 @@ describe("runs", () => {
           deleteResults: deleteResultsStub,
           getNumberOfSpecFiles: getNumberOfSpecFilesStub,
           setDefaults: setDefaultsStub,
-          setLocalConfigFile: setLocalConfigFileStub
+          setLocalConfigFile: setLocalConfigFileStub,
+          setBrowsers: setBrowsersStub,
+          setConfig: setConfigStub
         },
         '../helpers/capabilityHelper': {
           validate: capabilityValidatorStub,
@@ -497,6 +508,8 @@ describe("runs", () => {
       setDefaultsStub = sandbox.stub();
       stopLocalBinaryStub = sandbox.stub();
       setLocalConfigFileStub = sandbox.stub();
+      setConfigStub = sandbox.stub();
+      setBrowsersStub = sandbox.stub();
     });
 
     afterEach(() => {
@@ -534,7 +547,9 @@ describe("runs", () => {
           getNumberOfSpecFiles: getNumberOfSpecFilesStub,
           setDefaults: setDefaultsStub,
           stopLocalBinary: stopLocalBinaryStub,
-          setLocalConfigFile: setLocalConfigFileStub
+          setLocalConfigFile: setLocalConfigFileStub,
+          setBrowsers: setBrowsersStub,
+          setConfig: setConfigStub
         },
         '../helpers/capabilityHelper': {
           validate: capabilityValidatorStub,
@@ -652,6 +667,8 @@ describe("runs", () => {
       initTimeComponentsStub = sandbox.stub();
       markBlockStartStub = sandbox.stub();
       markBlockEndStub = sandbox.stub();
+      setConfigStub = sandbox.stub();
+      setBrowsersStub = sandbox.stub();
     });
 
     afterEach(() => {
@@ -693,6 +710,8 @@ describe("runs", () => {
           isUndefined: isUndefinedStub,
           getNumberOfSpecFiles: getNumberOfSpecFilesStub,
           setLocalConfigFile: setLocalConfigFileStub,
+          setBrowsers: setBrowsersStub,
+          setConfig: setConfigStub
         },
         '../helpers/capabilityHelper': {
           validate: capabilityValidatorStub,

test/unit/bin/helpers/fileHelpers.js

@@ -45,6 +45,22 @@ describe("fileHelpers", () => {
     expect(dataMock).to.eql(1);
   });
 
+  it("callback fn is executed after file write", () => {
+    let dataMock = 0;
+
+    let callbackStub = sandbox.stub().callsFake(() => {
+      dataMock = 1;
+    });
+
+    const fileExtraStub = sinon.stub(fs,'writeFile');
+    fileExtraStub.yields(true);
+    fileHelpers.write({path: "./random_path", file: "random"}, "writing successful", {}, callbackStub);
+    
+    sinon.assert.calledOnce(callbackStub);
+    sinon.assert.calledOnce(fileExtraStub);
+    expect(dataMock).to.eql(1);
+  });
+
   it("callback fn is executed after fileExists returns error", () => {
     let dataMock = undefined;
 

test/unit/bin/helpers/utils.js

@@ -2032,4 +2032,78 @@ describe('utils', () => {
     });
   });
 
+  describe('setConfig', () => {
+    it('the args config should be assigned to bsconfig run_settings config', () => {
+      let bsConfig = {
+        run_settings: {
+        }
+      };
+      let args = {
+        config: "pageLoadTimeout=60000"
+      };
+      utils.setConfig(bsConfig, args);
+      expect(args.config).to.be.eql(bsConfig.run_settings.config);
+    });
+  });
+
+  describe('setBrowsers', () => {
+    it('the args browser should override the bsconfig browsers', async () => {
+      let bsConfig = {
+        browsers: [
+          {
+            "browser": "chrome",
+            "os": "Windows 10",
+            "versions": ["latest", "latest-1"]
+          },
+          {
+            "browser": "chrome",
+            "os": "Windows 10",
+            "versions": ["latest", "latest-1"]
+          },
+        ]
+      };
+      let args = {
+        browser: "chrome@91:Windows 10,chrome:OS X Mojave"
+      };
+      let browserResult = [
+        {
+          "browser": "chrome",
+          "os": "Windows 10",
+          "versions": ["91"]
+        },
+        {
+          "browser": "chrome",
+          "os": "OS X Mojave",
+          "versions": ["latest"]
+        },
+      ]
+      await utils.setBrowsers(bsConfig, args);
+      expect(bsConfig.browsers).to.be.eql(browserResult);
+    });
+    it('the args browser should throw an error in case of exception raised', async () => {
+      let bsConfig = {
+        browsers: [
+          {
+            "browser": "chrome",
+            "os": "Windows 10",
+            "versions": ["latest", "latest-1"]
+          },
+          {
+            "browser": "chrome",
+            "os": "Windows 10",
+            "versions": ["latest", "latest-1"]
+          },
+        ]
+      };
+      let args = {
+        browser: ":Windows 10"
+      };
+      try {
+        await utils.setBrowsers(bsConfig, args);
+      } catch(err){{
+        expect(err).to.be.eql(constant.validationMessages.INVALID_BROWSER_ARGS);
+      }}
+    });
+  });
+
 });