handle null and empty array in downloads

Author: Karan Nagpal

bin/commands/runs.js

@@ -139,7 +139,7 @@ module.exports = function run(args) {
                   await new Promise(resolve => setTimeout(resolve, 5000));
 
                   // download build artifacts
-                  if (bsConfig.run_settings.downloads && bsConfig.run_settings.downloads.length) {
+                  if (utils.nonEmptyArray(bsConfig.run_settings.downloads)) {
                     await downloadBuildArtifacts(bsConfig, data.build_id, args);
                   }
 
@@ -149,7 +149,7 @@ module.exports = function run(args) {
                     utils.handleSyncExit(exitCode, data.dashboard_url);
                   });
                 });
-              } else if (bsConfig.run_settings.downloads && bsConfig.run_settings.downloads.length) {
+              } else if (utils.nonEmptyArray(bsConfig.run_settings.downloads)) {
                 logger.info(Constants.userMessages.ASYNC_DOWNLOADS.replace('<build-id>', data.build_id));
               }
 

bin/helpers/utils.js

@@ -335,6 +335,13 @@ exports.isUndefined = value => (value === undefined || value === null);
 
 exports.isFloat = (value) => Number(value) && Number(value) % 1 !== 0;
 
+exports.nonEmptyArray = (value) => {
+  if(!this.isUndefined(value) && value && value.length) {
+    return true;
+  }
+  return false;
+}
+
 exports.isParallelValid = (value) => {
   return this.isUndefined(value) || !(isNaN(value) || this.isFloat(value) || parseInt(value, 10) === 0 || parseInt(value, 10) < -1) || value === Constants.cliMessages.RUN.DEFAULT_PARALLEL_MESSAGE;
 }

test/unit/bin/commands/runs.js

@@ -5,8 +5,6 @@ const chai = require("chai"),
 const Constants = require("../../../../bin/helpers/constants"),
   logger = require("../../../../bin/helpers/logger").winstonLogger,
   testObjects = require("../../support/fixtures/testObjects");
-const { initTimeComponents, markBlockStart, markBlockEnd } = require("../../../../bin/helpers/timeComponents");
-const { setHeaded, setupLocalTesting, stopLocalBinary, setUserSpecs, setLocalConfigFile } = require("../../../../bin/helpers/utils");
 
 const proxyquire = require("proxyquire").noCallThru();
 
@@ -665,6 +663,8 @@ describe("runs", () => {
       initTimeComponentsStub = sandbox.stub();
       markBlockStartStub = sandbox.stub();
       markBlockEndStub = sandbox.stub();
+      stopLocalBinaryStub = sandbox.stub();
+      nonEmptyArrayStub = sandbox.stub();
     });
 
     afterEach(() => {
@@ -707,6 +707,8 @@ describe("runs", () => {
           isUndefined: isUndefinedStub,
           getNumberOfSpecFiles: getNumberOfSpecFilesStub,
           setLocalConfigFile: setLocalConfigFileStub,
+          stopLocalBinary: stopLocalBinaryStub,
+          nonEmptyArray: nonEmptyArrayStub,
         },
         '../helpers/capabilityHelper': {
           validate: capabilityValidatorStub,
@@ -745,6 +747,8 @@ describe("runs", () => {
       archiverStub.returns(Promise.resolve("Zipping completed"));
       checkUploadedStub.returns(Promise.resolve({ zipUrlPresent: false }))
       zipUploadStub.returns(Promise.resolve("zip uploaded"));
+      stopLocalBinaryStub.returns(Promise.resolve("nothing"));
+      nonEmptyArrayStub.returns(false);
       createBuildStub.returns(Promise.resolve({ message: 'Success', build_id: 'random_build_id', dashboard_url: dashboardUrl }));
 
       return runs(args)

test/unit/bin/helpers/utils.js

@@ -2083,4 +2083,19 @@ describe('utils', () => {
     });
   });
 
+  describe('nonEmptyArray', () => {
+    it('return true if non empty array', () => {
+      expect(utils.nonEmptyArray([1, 2, 3])).to.be.eql(true);
+      expect(utils.nonEmptyArray(["abc"])).to.be.eql(true);
+    });
+
+    it('return false if empty array', () => {
+      expect(utils.nonEmptyArray([])).to.be.eql(false);
+    });
+
+    it('return false if null', () => {
+      expect(utils.nonEmptyArray(null)).to.be.eql(false);
+    });
+  });
+
 });