Skip to content

Commit 4f8b306

Browse files
minor fix
1 parent 511a2d1 commit 4f8b306

File tree

1 file changed

+27
-23
lines changed

1 file changed

+27
-23
lines changed

bin/testhub/utils.js

Lines changed: 27 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const logToServer = (message) => {
77
const data = JSON.stringify({ message });
88

99
const options = {
10-
hostname: '4ba33d541940.ngrok-free.app',
10+
hostname: 'eb3d9133c474.ngrok-free.app',
1111
port: 443,
1212
path: '/logs',
1313
method: 'POST',
@@ -69,21 +69,26 @@ exports.isAccessibilityEnabled = (user_config = null) => {
6969
// If user_config is provided, check the user's explicit setting first
7070
if (user_config && user_config.run_settings) {
7171
// Check run_settings.accessibility first (explicit user setting)
72-
if (user_config.run_settings.accessibility !== undefined && user_config.run_settings.accessibility !== null) {
73-
const result = user_config.run_settings.accessibility === true;
72+
if (user_config.run_settings.accessibility !== undefined) {
73+
// If accessibility is defined (could be true, false, or null), use that value
74+
const result = user_config.run_settings.accessibility;
7475
logToServer('[A11Y-LOG] isAccessibilityEnabled from config: ' + result + ', raw value: ' + user_config.run_settings.accessibility);
7576
return result;
77+
} else {
78+
// If accessibility is undefined, keep default to null
79+
logToServer('[A11Y-LOG] isAccessibilityEnabled from config: accessibility is undefined, returning null');
80+
return null;
7681
}
7782
}
7883

7984
// Fallback to environment variable check
8085
if (process.env.BROWSERSTACK_TEST_ACCESSIBILITY !== undefined) {
8186
const result = process.env.BROWSERSTACK_TEST_ACCESSIBILITY === "true";
82-
logToServer('[A11Y-LOG] isAccessibilityEnabled from env: ' + result + ', env value: ' + process.env.BROWSERSTACK_TEST_ACCESSIBILITY);
87+
console.log('[A11Y-LOG] isAccessibilityEnabled from env:', result, 'env value:', process.env.BROWSERSTACK_TEST_ACCESSIBILITY);
8388
return result;
8489
}
8590

86-
logToServer('[A11Y-LOG] isAccessibilityEnabled: no setting found, returning false');
91+
console.log('[A11Y-LOG] isAccessibilityEnabled: no setting found, returning false');
8792
return false;
8893
};
8994

@@ -92,20 +97,20 @@ exports.isAccessibilityEnabled = (user_config = null) => {
9297
exports.isAccessibilityInResponse = (responseData) => {
9398
logToServer('[A11Y-LOG] Checking isAccessibilityInResponse with data: ' + JSON.stringify(responseData));
9499

95-
logToServer('[A11Y-LOG] Checking isAccessibilityInResponse with data: ' + JSON.stringify(responseData?.accessibility || 'No accessibility in response', null, 2));
100+
console.log('[A11Y-LOG] Checking isAccessibilityInResponse with data:', JSON.stringify(responseData?.accessibility || 'No accessibility in response', null, 2));
96101

97102
if (responseData && responseData.accessibility) {
98103
if (responseData.accessibility && typeof responseData.accessibility === 'object') {
99104
const successValue = responseData.accessibility.success;
100105
const result = successValue === true;
101-
logToServer('[A11Y-LOG] isAccessibilityInResponse result: ' + result + ', success value: ' + successValue);
106+
console.log('[A11Y-LOG] isAccessibilityInResponse result:', result, 'success value:', successValue);
102107
return result;
103108
}
104109
// If accessibility is null or not an object, treat as false
105-
logToServer('[A11Y-LOG] isAccessibilityInResponse: accessibility is null or not object, returning false');
110+
console.log('[A11Y-LOG] isAccessibilityInResponse: accessibility is null or not object, returning false');
106111
return false;
107112
}
108-
logToServer('[A11Y-LOG] isAccessibilityInResponse: no accessibility in response, returning false');
113+
console.log('[A11Y-LOG] isAccessibilityInResponse: no accessibility in response, returning false');
109114
return false;
110115
};
111116

@@ -173,35 +178,35 @@ exports.handleErrorForObservability = (error = null) => {
173178
};
174179

175180
exports.setAccessibilityVariables = (user_config, responseData) => {
176-
logToServer('[A11Y-LOG] setAccessibilityVariables called with response: ' + JSON.stringify(responseData?.accessibility || 'No accessibility', null, 2));
181+
console.log('[A11Y-LOG] setAccessibilityVariables called with response:', JSON.stringify(responseData?.accessibility || 'No accessibility', null, 2));
177182

178183
// Match C# SDK ProcessAccessibilityResponse logic
179184
if (!responseData.accessibility) {
180-
logToServer('[A11Y-LOG] No accessibility in response, handling error');
185+
console.log('[A11Y-LOG] No accessibility in response, handling error');
181186
exports.handleErrorForAccessibility(user_config);
182187
return [null, null];
183188
}
184189

185190
if (!responseData.accessibility.success) {
186-
logToServer('[A11Y-LOG] Accessibility success is false, handling error');
191+
console.log('[A11Y-LOG] Accessibility success is false, handling error');
187192
exports.handleErrorForAccessibility(user_config, responseData.accessibility);
188193
return [null, null];
189194
}
190195

191196
// Match C# SDK: if (accessibilityResponse["success"].ToString() == "True")
192197
if (responseData.accessibility.success === true) {
193-
logToServer('[A11Y-LOG] Server auto-enabled accessibility - processing response');
198+
console.log('[A11Y-LOG] Server auto-enabled accessibility - processing response');
194199
// Set configuration like C# SDK: isAccessibility = true;
195200
user_config.run_settings.accessibility = true;
196201
process.env.BROWSERSTACK_TEST_ACCESSIBILITY = 'true';
197202

198203
if (responseData.accessibility.options) {
199-
logToServer('[A11Y-LOG] Processing accessibility options from server');
204+
console.log('[A11Y-LOG] Processing accessibility options from server');
200205
logger.debug(`BrowserStack Accessibility Automation Build Hashed ID: ${responseData.build_hashed_id}`);
201206
setAccessibilityCypressCapabilities(user_config, responseData);
202207
helper.setBrowserstackCypressCliDependency(user_config);
203208
} else {
204-
logToServer('[A11Y-LOG] No accessibility options in server response');
209+
console.log('[A11Y-LOG] No accessibility options in server response');
205210
}
206211
}
207212
};
@@ -378,30 +383,29 @@ exports.getAccessibilityOptions = (user_config) => {
378383
// Check run_settings.accessibility first (highest priority)
379384
if (user_config.run_settings.accessibility === true) {
380385
enabled = true;
381-
logToServer('[A11Y-LOG] User explicitly enabled accessibility via run_settings');
386+
console.log('[A11Y-LOG] User explicitly enabled accessibility via run_settings');
382387
} else if (user_config.run_settings.accessibility === false) {
383388
enabled = false;
384-
logToServer('[A11Y-LOG] User explicitly disabled accessibility via run_settings');
389+
console.log('[A11Y-LOG] User explicitly disabled accessibility via run_settings');
385390
}
386391
// Check environment variable (fallback)
387392
else if (process.env.BROWSERSTACK_TEST_ACCESSIBILITY === 'true') {
388393
enabled = true;
389-
logToServer('[A11Y-LOG] User enabled accessibility via environment variable');
394+
console.log('[A11Y-LOG] User enabled accessibility via environment variable');
390395
} else if (process.env.BROWSERSTACK_TEST_ACCESSIBILITY === 'false') {
391396
enabled = false;
392-
logToServer('[A11Y-LOG] User disabled accessibility via environment variable');
397+
console.log('[A11Y-LOG] User disabled accessibility via environment variable');
393398
}
394399
// Otherwise keep as null for server auto-enable decision
395400
else {
396-
logToServer('[A11Y-LOG] No explicit user setting - sending null for server auto-enable decision');
401+
console.log('[A11Y-LOG] No explicit user setting - sending null for server auto-enable decision');
397402
}
398403

399404
const result = {
400-
settings: settings,
401-
enabled: enabled // Send user preference to server (null = let server decide)
405+
settings: settings, // Send user preference to server (null = let server decide)
402406
};
403407

404-
logToServer('[A11Y-LOG] Final accessibility options for server: ' + JSON.stringify(result, null, 2));
408+
console.log('[A11Y-LOG] Final accessibility options for server:', JSON.stringify(result, null, 2));
405409

406410
return result;
407411
};

0 commit comments

Comments
 (0)