Add test cases for part 2

Author: SagarGaniga

bin/helpers/constants.js

@@ -1,5 +1,9 @@
 const syncCLI = {
-  FAILED_SPEC_DETAILS_COL_HEADER: ['Spec', 'Status', 'Browser', 'BrowserStack Session ID']
+  FAILED_SPEC_DETAILS_COL_HEADER: ['Spec', 'Status', 'Browser', 'BrowserStack Session ID'],
+  LOGS: {
+    INIT_LOG: "Running Tests: ..."
+  },
+  INITIAL_DELAY_MULTIPLIER: 10
 };
 
 const userMessages = {

bin/helpers/sync/failedSpecsDetails.js

@@ -29,6 +29,9 @@ let failedSpecsDetails = (data) => {
     let specData = [specResultHeader]; // 2-D array
 
     data.forEach((spec) => {
+      if (spec.status.toLowerCase() === 'passed') {
+        return;
+      }
       if (spec.status && spec.status.toLowerCase() === 'failed' && !failedSpecs)
         failedSpecs = true;
 

bin/helpers/sync/syncSpecsLogs.js

@@ -4,6 +4,7 @@ const request = require("request"),
   utils = require("../utils"),
   logger = require("../logger").syncCliLogger,
   async = require('async'),
+  Constants = require("../constants"),
   tableStream = require('table').createStream,
   chalk = require('chalk');
 
@@ -30,26 +31,7 @@ let  getOptions = (auth, build_id) => {
 
 let getTableConfig = () => {
   return {
-    border: {
-      topBody: `-`,
-      topJoin: ``,
-      topLeft: ``,
-      topRight: ``,
-
-      bottomBody: `-`,
-      bottomJoin: ``,
-      bottomLeft: ``,
-      bottomRight: ``,
-
-      bodyLeft: ``,
-      bodyRight: ``,
-      bodyJoin: ``,
-
-      joinBody: ``,
-      joinLeft: ``,
-      joinRight: ``,
-      joinJoin: ``
-    },
+    border: getBorderConfig(),
     singleLine: true,
     columns: {
       0: { alignment: 'right' }
@@ -61,33 +43,52 @@ let getTableConfig = () => {
   };
 }
 
+let getBorderConfig = () => {
+  return {
+    topBody: `-`,
+    topJoin: ``,
+    topLeft: ``,
+    topRight: ``,
+
+    bottomBody: `-`,
+    bottomJoin: ``,
+    bottomLeft: ``,
+    bottomRight: ``,
+
+    bodyLeft: ``,
+    bodyRight: ``,
+    bodyJoin: ``,
+
+    joinBody: ``,
+    joinLeft: ``,
+    joinRight: ``,
+    joinJoin: ``
+  }
+}
+
 let printSpecsStatus = (bsConfig, buildDetails) => {
   return new Promise((resolve, reject) => {
     options = getOptions(bsConfig.auth, buildDetails.build_id)
     tableConfig = getTableConfig();
     stream = tableStream(tableConfig);
 
     async.whilst(
-      function() {
+      function() { // condition for loop
         return whileLoop;
       },
-      function(callback) {
+      function(callback) { // actual loop
         whileProcess(callback)
       },
-      function(err, result) {
-        if (err) {
-          reject(err)
-        } else {
-          specSummary.duration =  endTime - startTime
-          logger.info();
-          resolve(specSummary)
-        }
+      function(err, result) { // when loop ends
+        specSummary.duration =  endTime - startTime
+        logger.info();
+        resolve(specSummary)
       }
     );
   });
 };
 
-function whileProcess(whilstCallback) {
+let whileProcess = (whilstCallback) => {
   request.post(options, function(error, response, body) {
     if (error) {
       return whilstCallback(error);
@@ -107,10 +108,6 @@ function whileProcess(whilstCallback) {
         return whilstCallback(null, body);
       default:
         whileLoop = false;
-        whileTries -= 1;
-        if (whileTries === 0) {
-          return whilstCallback({ status: 504, message: "Tries limit reached" }); //Gateway Timeout
-        }
         return whilstCallback({ status: response.statusCode, message: body });
     }
   });
@@ -120,33 +117,40 @@ let showSpecsStatus = (data) => {
   let specData = JSON.parse(data);
   specData.forEach(specDetails => {
     if (specDetails == "created") {
-      startTime = Date.now();
-      logger.info("Running Tests: ...")
-      n = 10
+      printInitialLog();
     } else {
       try {
-        specDetails = JSON.parse(specDetails)
-        printSpecData(specDetails)
+        printSpecData(JSON.parse(specDetails))
       } catch (error) {
       }
     }
   });
 }
 
+let printInitialLog = () => {
+  startTime = Date.now();
+  logger.info(Constants.syncCLI.LOGS.INIT_LOG)
+  n = Constants.syncCLI.INITIAL_DELAY_MULTIPLIER
+}
+
 let printSpecData = (data) => {
   let combination = getCombinationName(data["spec"]);
-  let specName = data["path"]
   let status = getStatus(data["spec"]["status"]);
+  writeToTable(combination, data["path"], status)
+  addSpecToSummary(data["path"], data["spec"]["status"], combination, data["session_id"])
+}
 
+let writeToTable = (combination, specName, status) => {
   stream.write([combination + ":", `${specName} ${status}`]);
+}
 
-  // for part 3
-  // Format: {specName: 'spec1.failed.js', status: 'Failed', combination: 'Win 10 / Chrome 78', sessionId: '3d3rdf3r...'},
+let addSpecToSummary = (specName, status, combination, session_id) => {
+  // Format for part 3: {specName: 'spec1.failed.js', status: 'Failed', combination: 'Win 10 / Chrome 78', sessionId: '3d3rdf3r...'},
   specSummary["specs"].push({
     "specName": specName,
-    "status": data["spec"]["status"],
+    "status": status,
     "combination": combination,
-    "sessionId": data["session_id"]
+    "sessionId": session_id
   })
 }
 

test/unit/bin/helpers/sync/specSummary.js

@@ -10,7 +10,7 @@ var specSummary = require('../../../../../bin/helpers/sync/specsSummary');
 
 describe("printSpecsRunSummary", () => {
   context("data is empty", () => {
-    let data = [], time = '2 minutes', machines = 2;
+    let data = [], time = 6000, machines = 2;
     it('returns passed specs data', () => {
       return specSummary.printSpecsRunSummary(data, time, machines).then((specsData) => {
         expect(data).to.equal(specsData);
@@ -19,7 +19,7 @@ describe("printSpecsRunSummary", () => {
   });
 
   context("with data", () => {
-    let time = '2 minutes',
+    let time = 6000,
         machines = 2,
         data = [
           {specName: 'spec2.name.js', status: 'Failed', combination: 'Win 10 / Chrome 78', sessionId: '3d3rdf3r...'},
@@ -33,7 +33,7 @@ describe("printSpecsRunSummary", () => {
 
       specSummary.printSpecsRunSummary(data, time, machines);
       sinon.assert.calledWith(loggerInfoSpy, 'Total tests: 4, passed: 1, failed: 2, skipped: 1');
-      sinon.assert.calledWith(loggerInfoSpy, `Done in ${time} using ${machines} machines\n`);
+      sinon.assert.calledWith(loggerInfoSpy, `Done in ${time / 1000} seconds using ${machines} machines\n`);
 
       loggerInfoSpy.restore();
     });