Added more tests for specific cases and exit code status

Author: suryart

bin/helpers/sync/failedSpecsDetails.js

@@ -1,5 +1,7 @@
-const { table, getBorderCharacters } = require('table'),
-      chalk = require('chalk');
+const tablePrinter = require('table'), // { table, getBorderCharacters }
+      chalk = require('chalk'),
+      Constants = require("../constants"),
+      logger = require("../logger").syncCliLogger;
 
 /**
  *
@@ -36,7 +38,7 @@ let failedSpecsDetails = (data) => {
     });
 
     let config = {
-      border: getBorderCharacters('ramac'),
+      border: tablePrinter.getBorderCharacters('ramac'),
       columns: {
         0: { alignment: 'left' },
         1: { alignment: 'left' },
@@ -54,7 +56,7 @@ let failedSpecsDetails = (data) => {
       }
     }
 
-    let result = table(specData, config);
+    let result = tablePrinter.table(specData, config);
 
     logger.info('Failed / skipped test report');
     logger.info(result);

test/unit/bin/helpers/sync/failedSpecDetails.js

@@ -1,18 +1,17 @@
 'use strict';
 const chai = require("chai"),
   expect = chai.expect,
-  sinon = require('sinon'),
-  chaiAsPromised = require("chai-as-promised"),
-  fs = require('fs');
+  chaiAsPromised = require("chai-as-promised");
 
+chai.use(chaiAsPromised);
 const specDetails = require('../../../../../bin/helpers/sync/failedSpecsDetails');
 
 describe("failedSpecsDetails", () => {
   context("data is empty", () => {
     let data = [];
     it('returns 0 exit code', () => {
-      specDetails.failedSpecsDetails(data).then((status) => {
-        chai.assert.equal(data, 0);
+      return specDetails.failedSpecsDetails(data).then((status) => {
+        expect(status).to.equal(0);
       });
     });
   });
@@ -23,8 +22,24 @@ describe("failedSpecsDetails", () => {
     ];
 
     it("returns 0 exit code", () => {
-      specDetails.failedSpecsDetails(data).then((status) => {
-        chai.assert.equal(data, 0);
+      return specDetails.failedSpecsDetails(data).then((status) => {
+        expect(status).to.equal(0);
+      });
+    });
+  });
+
+  context("data has failed specs", () => {
+    let data = [
+      {specName: 'spec2.name.js', status: 'Failed', combination: 'Win 10 / Chrome 78', sessionId: '3d3rdf3r...'}
+    ];
+
+    it("returns 1 exit code", () => {
+      return specDetails.failedSpecsDetails(data)
+        .then((status) => {
+          chai.assert.equal(status, 1);
+          expect(status).to.equal(1);
+        }).catch((status) => {
+          expect(status).to.equal(1);
       });
     });
   });