🎨 added isNotUndefined check for timezone

Author: Archish27

bin/helpers/utils.js

@@ -404,7 +404,7 @@ exports.isValidTimezone = (timezone) => {
 exports.setTimezone = (bsConfig, args) => {
   let timezone = undefined;
   if(this.isTimezoneArgPassed()) {
-    if(!this.isUndefined(args.timezone)) { 
+    if(this.isNotUndefined(args.timezone)) { 
       if(this.isValidTimezone(args.timezone)){
         timezone = args.timezone; 
       } else {
@@ -413,7 +413,7 @@ exports.setTimezone = (bsConfig, args) => {
         process.exit(1);
       }
     }
-  } else if (!this.isUndefined(bsConfig.run_settings.timezone)) {
+  } else if (this.isNotUndefined(bsConfig.run_settings.timezone)) {
     if(this.isValidTimezone(bsConfig.run_settings.timezone)){
       timezone = bsConfig.run_settings.timezone; 
     } else {
@@ -591,6 +591,8 @@ exports.fixCommaSeparatedString = (string) => {
 
 exports.isUndefined = value => (value === undefined || value === null);
 
+exports.isNotUndefined = value => !this.isUndefined(value);
+
 exports.isPositiveInteger = (str) => {
   if (typeof str !== 'string') {
     return false;

test/unit/bin/helpers/utils.js

@@ -192,6 +192,20 @@ describe('utils', () => {
     });
   });
 
+  describe('isNotUndefined', () => {
+    it('should return false for a undefined value', () => {
+      expect(utils.isNotUndefined(undefined)).to.be.equal(false);
+      expect(utils.isNotUndefined(null)).to.be.equal(false);
+    });
+
+    it('should return true for a defined value', () => {
+      expect(utils.isNotUndefined(1.234)).to.be.equal(true);
+      expect(utils.isNotUndefined('1.234')).to.be.equal(true);
+      expect(utils.isNotUndefined(100)).to.be.equal(true);
+      expect(utils.isNotUndefined(-1)).to.be.equal(true);
+    });
+  });
+
   describe('setParallels', () => {
     var sandbox;
     beforeEach(() => {