Merge branch 'main' of github.com:browserstack/a11y-engine-axe-core into a11y-commons

Author: mattscepter

lib/checks/color/link-in-text-block-evaluate.js

@@ -28,6 +28,10 @@ function isBlock(elm) {
 }
 
 function linkInTextBlockEvaluate(node) {
+  if(node.getAttribute('type') ==='button' || node.tagName.toLowerCase() === 'button' || node.getAttribute('role') === 'button') {
+    return true;
+  }
+
   var options = arguments.length > 1 && arguments[1] ? arguments[1] : {};
   if (isBlock(node)) {
     return false;

lib/checks/forms/autocomplete-a11y-evaluate.js

@@ -0,0 +1,54 @@
+import { isValidAutocomplete } from "../../commons/text";
+
+function checkIsElementValidAutocomplete(node, options, virtualNode) {
+    const autocomplete = virtualNode.attr('autocomplete')?.toLowerCase().trim();
+    // if element has autocomplete attribute as off then it is not a violation
+    if(autocomplete === "off") {
+      return true;
+    } 
+  
+    // if it is on then we check whether name / id have valid autocomplete value or not
+    // same for the case if autocomplete is not present or has a non-standard value
+    if(!autocomplete || autocomplete === "on" || !isValidAutocomplete(autocomplete, options)) {
+      const name = virtualNode.attr('name');
+      const id = virtualNode.attr('id');
+      if((name && isValidAutocomplete(name, options)) || (id && isValidAutocomplete(id, options)))
+        return true;
+      return false;
+    }
+  
+    // if element autocomplete attribute is neither off nor on then we check if its a standard value
+    if(isValidAutocomplete(autocomplete, options)) {
+      return true;
+    }
+  
+    return false;
+  }
+  
+  function autocompleteA11yEvaluate(node, options, virtualNode) {
+    try {
+      const autocomplete = virtualNode.attr('autocomplete');
+  
+      // check if the autocomplete applicable element is inside form or exist freely
+      const closestForm = virtualNode.actualNode.closest("form");
+  
+      //if it exists inside the form and autocomplete for form is off
+      if(closestForm && closestForm.getAttribute('autocomplete')?.toLowerCase().trim() === "off") {
+        // if autocomplete attribute is not present for element then its a pass in this scenario
+        // otherwise check all posibilities with the method
+        return autocomplete ? checkIsElementValidAutocomplete(node, options, virtualNode) : true;
+      } else {
+        // The else case is if form is present and it has autocomplete as on or not set and 
+        // the other case this handles is that element exists independently
+  
+        // this method would check for all posibilities
+        return checkIsElementValidAutocomplete(node, options, virtualNode);
+      }  
+    }
+    catch(err) {
+      ErrorHandler.addCheckError("autocomplete-attribute-valid-check", err);
+      return undefined;
+    }
+  }
+  
+  export default autocompleteA11yEvaluate;

lib/checks/forms/autocomplete-valid.json

@@ -1,6 +1,6 @@
 {
   "id": "autocomplete-valid",
-  "evaluate": "autocomplete-valid-evaluate",
+  "evaluate": "autocomplete-a11y-evaluate",
   "metadata": {
     "impact": "serious",
     "messages": {

lib/rules/autocomplete-a11y-matches.js

@@ -0,0 +1,10 @@
+import autocompleteMatches from "./autocomplete-matches";
+
+function autocompleteA11yMatches(node, virtualNode) { 
+    const a11yEngineFlag = true;
+    // the flag is used to tell autocomplete matcher that it is being called 
+    // by a11y-engine and thus bypass an if block
+    return autocompleteMatches(node, virtualNode, a11yEngineFlag);
+ }
+ 
+ export default autocompleteA11yMatches;

lib/rules/autocomplete-matches.js

@@ -2,9 +2,9 @@ import { sanitize } from '../commons/text';
 import standards from '../standards';
 import { isVisible } from '../commons/dom';
 
-function autocompleteMatches(node, virtualNode) {
+function autocompleteMatches(node, virtualNode, flag=false) {
   const autocomplete = virtualNode.attr('autocomplete');
-  if (!autocomplete || sanitize(autocomplete) === '') {
+  if ((!autocomplete || sanitize(autocomplete) === '') && !flag) {
     return false;
   }
 

lib/rules/autocomplete-valid.json

@@ -1,6 +1,6 @@
 {
   "id": "autocomplete-valid",
-  "matches": "autocomplete-matches",
+  "matches": "autocomplete-a11y-matches",
   "tags": ["cat.forms", "wcag21aa", "wcag135"],
   "actIds": ["73f2c2"],
   "metadata": {