Updated test cases

Author: chikara1608

lib/checks/forms/autocomplete-a11y-evaluate.js

@@ -1,55 +1,77 @@
-import { isValidAutocomplete } from "../../commons/text";
+import { isValidAutocomplete } from '../../commons/text';
+import { ErrorHandler } from '../../../../a11y-engine-core/lib/core/errors/error-handler';
 
 function checkIsElementValidAutocomplete(node, options, virtualNode) {
-    const autocomplete = virtualNode.attr('autocomplete')?.toLowerCase().trim();
-    // if element has autocomplete attribute as off then it is not a violation
-    if(autocomplete === "off" || autocomplete==="chrome-off") {
-      return true;
-    } 
-  
-    // if it is on then we check whether name / id have valid autocomplete value or not
-    // same for the case if autocomplete is not present or has a non-standard value
-    if(!autocomplete || autocomplete === "on" || !isValidAutocomplete(autocomplete, options)) {
-      const name = virtualNode.attr('name');
-      const id = virtualNode.attr('id');
-      if((name && isValidAutocomplete(name, options)) || (id && isValidAutocomplete(id, options)))
-        return true;
-      return false;
-    }
-  
-    // if element autocomplete attribute is neither off nor on then we check if its a standard value
-    if(isValidAutocomplete(autocomplete, options)) {
+  const autocomplete = virtualNode
+    .attr('autocomplete')
+    ?.toLowerCase()
+    .trim();
+  // if element has autocomplete attribute as off then it is not a violation
+  if (autocomplete === 'off' || autocomplete === 'chrome-off') {
+    return true;
+  }
+
+  // if it is on then we check whether name / id have valid autocomplete value or not
+  // same for the case if autocomplete is not present or has a non-standard value
+  if (
+    !autocomplete ||
+    autocomplete === 'on' ||
+    !isValidAutocomplete(autocomplete, options)
+  ) {
+    const name = virtualNode.attr('name');
+    const id = virtualNode.attr('id');
+    if (
+      (name && isValidAutocomplete(name, options)) ||
+      (id && isValidAutocomplete(id, options))
+    ) {
       return true;
     }
-  
     return false;
   }
-  
-  function autocompleteA11yEvaluate(node, options, virtualNode) {
-    try {
-      const autocomplete = virtualNode.attr('autocomplete');
-  
-      // check if the autocomplete applicable element is inside form or exist freely
-      const closestForm = virtualNode.actualNode.closest("form");
-  
-      //if it exists inside the form and autocomplete for form is off
-      if(closestForm && (closestForm.getAttribute('autocomplete')?.toLowerCase().trim() === "off" 
-        || closestForm.getAttribute('autocomplete')?.toLowerCase().trim() === "chrome-off")) {
-        // if autocomplete attribute is not present for element then its a pass in this scenario
-        // otherwise check all posibilities with the method
-        return autocomplete ? checkIsElementValidAutocomplete(node, options, virtualNode) : true;
-      } else {
-        // The else case is if form is present and it has autocomplete as on or not set and 
-        // the other case this handles is that element exists independently
-  
-        // this method would check for all posibilities
-        return checkIsElementValidAutocomplete(node, options, virtualNode);
-      }  
-    }
-    catch(err) {
-      ErrorHandler.addCheckError("autocomplete-attribute-valid-check", err);
-      return undefined;
+
+  // if element autocomplete attribute is neither off nor on then we check if its a standard value
+  if (isValidAutocomplete(autocomplete, options)) {
+    return true;
+  }
+
+  return false;
+}
+
+function autocompleteA11yEvaluate(node, options, virtualNode) {
+  try {
+    const autocomplete = virtualNode.attr('autocomplete');
+
+    // check if the autocomplete applicable element is inside form or exist freely
+    const closestForm = virtualNode.actualNode.closest('form');
+
+    //if it exists inside the form and autocomplete for form is off
+    if (
+      closestForm &&
+      (closestForm
+        .getAttribute('autocomplete')
+        ?.toLowerCase()
+        .trim() === 'off' ||
+        closestForm
+          .getAttribute('autocomplete')
+          ?.toLowerCase()
+          .trim() === 'chrome-off')
+    ) {
+      // if autocomplete attribute is not present for element then its a pass in this scenario
+      // otherwise check all posibilities with the method
+      return autocomplete
+        ? checkIsElementValidAutocomplete(node, options, virtualNode)
+        : true;
+    } else {
+      // The else case is if form is present and it has autocomplete as on or not set and
+      // the other case this handles is that element exists independently
+
+      // this method would check for all posibilities
+      return checkIsElementValidAutocomplete(node, options, virtualNode);
     }
+  } catch (err) {
+    ErrorHandler.addCheckError('autocomplete-attribute-valid-check', err);
+    return undefined;
   }
-  
-  export default autocompleteA11yEvaluate;
+}
+
+export default autocompleteA11yEvaluate;

test/integration/rules/autocomplete-valid/autocomplete-valid.html

@@ -152,10 +152,10 @@
 <input autocomplete="cc-csc" type="tel" id="pass77" />
 
 <!-- Attribute values that contains synonyms of on/off -->
-<input autocomplete="none" id="fail11" />
-<input autocomplete="false" id="fail12" />
-<input autocomplete="true" id="fail13" />
-<input autocomplete="disabled" id="fail14" />
-<input autocomplete="enabled" id="fail15" />
-<input autocomplete="undefined" id="fail16" />
-<input autocomplete="null" id="fail17" />
+<input autocomplete="none" id="pass78" />
+<input autocomplete="false" id="pass79" />
+<input autocomplete="true" id="pass80" />
+<input autocomplete="disabled" id="pass81" />
+<input autocomplete="enabled" id="pass82" />
+<input autocomplete="undefined" id="pass83" />
+<input autocomplete="null" id="pass84" />

test/integration/rules/autocomplete-valid/autocomplete-valid.json

@@ -11,14 +11,7 @@
     ["#fail7"],
     ["#fail8"],
     ["#fail9"],
-    ["#fail10"],
-    ["#fail11"],
-    ["#fail12"],
-    ["#fail13"],
-    ["#fail14"],
-    ["#fail15"],
-    ["#fail16"],
-    ["#fail17"]
+    ["#fail10"]
   ],
   "passes": [
     ["#pass1"],
@@ -98,6 +91,12 @@
     ["#pass75"],
     ["#pass76"],
     ["#pass77"],
-    ["#pass78"]
+    ["#pass78"],
+    ["#pass79"],
+    ["#pass80"],
+    ["#pass81"],
+    ["#pass82"],
+    ["#pass83"],
+    ["#pass84"]
   ]
 }