Added changes in get-visible-child-text-child

Author: mattscepter

lib/commons/dom/get-visible-child-text-rects.js

@@ -12,7 +12,12 @@ import cache from '../../core/base/cache';
  * @param {Element} node
  */
 const getVisibleChildTextRects = memoize(
-  function getVisibleChildTextRectsMemoized(node) {
+  function getVisibleChildTextRectsMemoized(
+    node,
+    checkTextRectOutsideNodeBoundingRect = false,
+    checkIsOutsideNodeBounds = true,
+    includeOverflowHiddenRect = false
+  ) {
     const vNode = getNodeFromTree(node);
     const nodeRect = vNode.boundingClientRect;
     const clientRects = [];
@@ -24,18 +29,34 @@ const getVisibleChildTextRects = memoize(
       }
 
       const contentRects = getContentRects(textNode);
-      if (isOutsideNodeBounds(contentRects, nodeRect) && !cache.get('ruleId')) {
-        return;
+      if (checkIsOutsideNodeBounds) {
+        if (
+          isOutsideNodeBounds(
+            contentRects,
+            nodeRect,
+            checkTextRectOutsideNodeBoundingRect
+          ) &&
+          !cache.get('ruleId')
+        ) {
+          return;
+        }
       }
 
-      clientRects.push(...filterHiddenRects(contentRects, overflowHiddenNodes));
+      if (includeOverflowHiddenRect) {
+        clientRects.push(
+          ...filterHiddenRects(contentRects, overflowHiddenNodes)
+        );
+      } else {
+        clientRects.push(...filterHiddenRects(contentRects, []));
+      }
     });
 
     // a11y-engine-domforge change
     if (
       clientRects.length <= 0 &&
       cache.get('ruleId') &&
-      cache.get('ruleId') === 'resize-2x-zoom'
+      cache.get('ruleId') === 'resize-2x-zoom' &&
+      checkIsOutsideNodeBounds
     ) {
       return [];
     }
@@ -72,10 +93,18 @@ function getContentRects(node) {
  * when determining the rect stack we will also use the midpoint
  * of the text rect to determine out of bounds
  */
-function isOutsideNodeBounds(rects, nodeRect) {
+function isOutsideNodeBounds(
+  rects,
+  nodeRect,
+  checkTextRectOutsideNodeBoundingRect = false
+) {
   return rects.some(rect => {
     const centerPoint = getRectCenter(rect);
-    return !isPointInRect(centerPoint, nodeRect);
+    if (checkTextRectOutsideNodeBoundingRect) {
+      !isPointInRect(centerPoint, nodeRect) || rect.right > nodeRect.right;
+    } else {
+      return !isPointInRect(centerPoint, nodeRect);
+    }
   });
 }