[Refactor] make maybeUnwrapSymlink

Author: ljharb

lib/async.js

@@ -25,6 +25,17 @@ var defaultIsDir = function isDirectory(dir, cb) {
     });
 };
 
+var maybeUnwrapSymlink = function maybeUnwrapSymlink(x, opts, cb) {
+    if (!opts || !opts.preserveSymlinks) {
+        fs.realpath(x, function (realPathErr, realPath) {
+            if (realPathErr && realPathErr.code !== 'ENOENT') cb(realPathErr);
+            else cb(null, realPathErr ? x : realPath);
+        });
+    } else {
+        cb(null, x);
+    }
+};
+
 module.exports = function resolve(x, options, callback) {
     var cb = callback;
     var opts = options;
@@ -54,14 +65,14 @@ module.exports = function resolve(x, options, callback) {
     // ensure that `basedir` is an absolute path at this point, resolving against the process' current working directory
     var absoluteStart = path.resolve(basedir);
 
-    if (!opts || !opts.preserveSymlinks) {
-        fs.realpath(absoluteStart, function (realPathErr, realStart) {
-            if (realPathErr && realPathErr.code !== 'ENOENT') cb(err);
-            else validateBasedir(realPathErr ? absoluteStart : realStart);
-        });
-    } else {
-        validateBasedir(absoluteStart);
-    }
+    maybeUnwrapSymlink(
+        absoluteStart,
+        opts,
+        function (err, realStart) {
+            if (err) cb(err);
+            else validateBasedir(realStart);
+        }
+    );
 
     function validateBasedir(basedir) {
         if (opts.basedir) {

lib/sync.js

@@ -25,6 +25,19 @@ var defaultIsDir = function isDirectory(dir) {
     return stat.isDirectory();
 };
 
+var maybeUnwrapSymlink = function maybeUnwrapSymlink(x, opts) {
+    if (!opts || !opts.preserveSymlinks) {
+        try {
+            return fs.realpathSync(x);
+        } catch (realPathErr) {
+            if (realPathErr.code !== 'ENOENT') {
+                throw realPathErr;
+            }
+        }
+    }
+    return x;
+};
+
 module.exports = function (x, options) {
     if (typeof x !== 'string') {
         throw new TypeError('Path must be a string.');
@@ -42,17 +55,7 @@ module.exports = function (x, options) {
     opts.paths = opts.paths || [];
 
     // ensure that `basedir` is an absolute path at this point, resolving against the process' current working directory
-    var absoluteStart = path.resolve(basedir);
-
-    if (!opts.preserveSymlinks) {
-        try {
-            absoluteStart = fs.realpathSync(absoluteStart);
-        } catch (realPathErr) {
-            if (realPathErr.code !== 'ENOENT') {
-                throw realPathErr;
-            }
-        }
-    }
+    var absoluteStart = maybeUnwrapSymlink(path.resolve(basedir), opts);
 
     if (opts.basedir && !isDirectory(absoluteStart)) {
         var dirError = new TypeError('Provided basedir "' + opts.basedir + '" is not a directory' + (opts.preserveSymlinks ? '' : ', or a symlink to a directory'));