Skip fake typed array test in FF

goto-bus-stop · goto-bus-stop · commit 8a7cde38085d · 2019-05-01T11:28:29.000+02:00
diff --git a/test/node/types.js b/test/node/types.js
@@ -142,7 +142,9 @@ console.log('Testing', 'isBoxedPrimitive');
 
 var SymbolSupported = typeof Symbol !== 'undefined';
 var SymbolToStringTagSupported = SymbolSupported && typeof Symbol.toStringTag !== 'undefined';
-if (SymbolToStringTagSupported) {
+var isBuggyFirefox = typeof navigator !== 'undefined' && /Firefox\/\d+/.test(navigator.userAgent) &&
+  parseInt(navigator.userAgent.split('Firefox/')[1], 10) < 66
+if (SymbolToStringTagSupported && !isBuggyFirefox) {
   [
     'Uint8Array',
     'Uint8ClampedArray',
@@ -169,6 +171,9 @@ if (SymbolToStringTagSupported) {
     assert(types[method](array));
   });
 }
+if (isBuggyFirefox) {
+  console.log('skipping fake typed array tests because they do not work in FF')
+}
 
 {
   var primitive = function primitive() { return true; };

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,9 @@ console.log('Testing', 'isBoxedPrimitive');`
`142`	`142`
`143`	`143`	`var SymbolSupported = typeof Symbol !== 'undefined';`
`144`	`144`	`var SymbolToStringTagSupported = SymbolSupported && typeof Symbol.toStringTag !== 'undefined';`
`145`		`-if (SymbolToStringTagSupported) {`
	`145`	`+var isBuggyFirefox = typeof navigator !== 'undefined' && /Firefox\/\d+/.test(navigator.userAgent) &&`
	`146`	`+ parseInt(navigator.userAgent.split('Firefox/')[1], 10) < 66`
	`147`	`+if (SymbolToStringTagSupported && !isBuggyFirefox) {`
`146`	`148`	`[`
`147`	`149`	`'Uint8Array',`
`148`	`150`	`'Uint8ClampedArray',`
`@@ -169,6 +171,9 @@ if (SymbolToStringTagSupported) {`
`169`	`171`	`assert(types[method](array));`
`170`	`172`	`});`
`171`	`173`	`}`
	`174`	`+if (isBuggyFirefox) {`
	`175`	`+ console.log('skipping fake typed array tests because they do not work in FF')`
	`176`	`+}`
`172`	`177`
`173`	`178`	`{`
`174`	`179`	`var primitive = function primitive() { return true; };`