Test for Buffer in isUint8Array if no Symbol.toStringTag support

Otherwise we can't detect buffers. However this also means we'll incorrectly detect fake buffers, so skip the fake buffer test.

Author: lukechilds

support/types.js

@@ -3,6 +3,8 @@
 
 'use strict';
 
+var isBuffer = require('./isBuffer');
+
 var isArgumentsObject = require('is-arguments');
 var isGeneratorFunction = require('is-generator-function');
 var isPromise = require('is-promise');
@@ -96,7 +98,10 @@ function isUint8Array(value) {
   if (Uint8ArraySupported && SymbolToStringTagSupported) {
     return TypedArrayProto_toStringTag(value) === 'Uint8Array';
   } else {
-    return ObjectToString(value) === '[object Uint8Array]';
+    return (
+      ObjectToString(value) === '[object Uint8Array]' ||
+      isBuffer(value)
+    );
   }
 }
 exports.isUint8Array = isUint8Array;

test/node/types.js

@@ -182,7 +182,12 @@ if (SymbolToStringTagSupported) {
   var bigInt64Array = function bigInt64Array() { return new BigInt64Array(arrayBuffer()); };
   var bigUint64Array = function bigUint64Array() { return new BigUint64Array(arrayBuffer()); };
 
-  var fakeBuffer = function fakeBuffer() { return Object.create(Buffer.prototype); };
+  var fakeBuffer = function fakeBuffer() {
+    if (!SymbolToStringTagSupported) {
+      throw new Error();
+    }
+    return Object.create(Buffer.prototype);
+  };
   var fakeDataView = function fakeDataView() { return Object.create(DataView.prototype); };
   var fakeUint8Array = function fakeUint8Array() { return Object.create(Uint8Array.prototype); };
   var fakeUint8ClampedArray = function fakeUint8ClampedArray() { return Object.create(Uint8ClampedArray.prototype); };