Skip to content

Commit a4e5516

Browse files
author
Chris Brody
authored
Merge pull request #18 from brodybits/0.5.0-updates
0.5.0 updates
2 parents 22dbd27 + 42fd299 commit a4e5516

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

templates/android.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ module.exports = platform => [{
77
}
88
99
dependencies {
10-
// Matches the RN Hello World template
11-
// https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/local-cli/templates/HelloWorld/android/build.gradle#L8
12-
classpath 'com.android.tools.build:gradle:3.2.1'
10+
// Matches recent template from React Native (0.59)
11+
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L16
12+
classpath 'com.android.tools.build:gradle:3.3.2'
1313
}
1414
}
1515
@@ -20,10 +20,12 @@ def safeExtGet(prop, fallback) {
2020
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
2121
}
2222
23+
// Matches values in recent template from React Native (0.59)
24+
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L5-L9
2325
def DEFAULT_COMPILE_SDK_VERSION = 28
24-
def DEFAULT_BUILD_TOOLS_VERSION = "28.0.2"
26+
def DEFAULT_BUILD_TOOLS_VERSION = "28.0.3"
2527
def DEFAULT_MIN_SDK_VERSION = 16
26-
def DEFAULT_TARGET_SDK_VERSION = 27
28+
def DEFAULT_TARGET_SDK_VERSION = 28
2729
2830
android {
2931
compileSdkVersion safeExtGet('compileSdkVersion', DEFAULT_COMPILE_SDK_VERSION)
@@ -43,8 +45,8 @@ android {
4345
repositories {
4446
maven {
4547
// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
46-
// Matches the RN Hello World template
47-
// https://github.com/facebook/react-native/blob/1e8f3b11027fe0a7514b4fc97d0798d3c64bc895/local-cli/templates/HelloWorld/android/build.gradle#L21
48+
// Matches recent template from React Native (0.59)
49+
// https://github.com/facebook/react-native/blob/0.59-stable/template/android/build.gradle#L30
4850
url "$projectDir/../node_modules/react-native/android"
4951
}
5052
mavenCentral()

templates/general.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ ${name};
8888
const devDependencies =
8989
`{
9090
"react": "^16.5.0",
91-
"react-native": "0.59.3"` +
91+
"react-native": "^0.59.4"` +
9292
(withWindows
9393
? `,
9494
"react-native-windows": "^0.57.1"`

0 commit comments

Comments
 (0)