Skip to content

Commit 6d4aaad

Browse files
BUGFIX: Remove invalid isActive property from IconButton
1 parent cfc15c3 commit 6d4aaad

File tree

3 files changed

+65
-37309
lines changed

3 files changed

+65
-37309
lines changed

Configuration/Settings.yaml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,19 @@
11
Neos:
22
Neos:
33
Ui:
4+
frontendConfiguration:
5+
'Breadlesscode.SimpleEditorExtend:Buttons':
6+
'Test.Test:MyCustomSpan':
7+
extensionName: 'exampleExtension'
8+
icon: 'plus-square'
9+
tooltip: 'Mark the text in color green'
10+
position: 'before strong'
11+
formatting:
12+
tag: 'span'
13+
classes: 'test-class'
14+
styles:
15+
background-color: 'green'
416
resources:
517
javascript:
618
'Breadlesscode.SimpleEditorExtend:UiPlugin':
7-
resource: resource://Breadlesscode.SimpleEditorExtend/Public/UiPlugin/Plugin.js
19+
resource: resource://Breadlesscode.SimpleEditorExtend/Public/UiPlugin/Plugin.js

Resources/Private/UiPlugin/src/ButtonComponent.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ export default function (commandName) {
1212
static propTypes = {
1313
i18nRegistry: PropTypes.object,
1414
tooltip: PropTypes.string,
15-
isActive: PropTypes.boolean,
1615
};
1716
handleClick = () => {
1817
// this command name must match the identifier of the command from examplePlugin.js, this.editor.commands.add(...)
@@ -21,7 +20,6 @@ export default function (commandName) {
2120
render() {
2221
const props = {
2322
onClick: this.handleClick,
24-
isActive: Boolean(this.props.isActive),
2523
title: this.props.i18nRegistry.translate(this.props.tooltip),
2624
icon: this.props.icon,
2725
};

0 commit comments

Comments
 (0)