fix cargo clippy (#513)

Author: atuchin-m

tests/live.rs

@@ -24,9 +24,8 @@ fn load_requests() -> Vec<RequestRuleMatch> {
         .from_reader(reader);
 
     let mut reqs: Vec<RequestRuleMatch> = Vec::new();
-    for result in rdr.deserialize() {
-        if result.is_ok() {
-            let record: RequestRuleMatch = result.unwrap();
+    for result in rdr.deserialize::<RequestRuleMatch>() {
+        if let Ok(record) = result {
             reqs.push(RequestRuleMatch {
                 url: record.url.trim_matches('"').to_owned(),
                 sourceUrl: record.sourceUrl.trim_matches('"').to_owned(),

tests/matching.rs

@@ -74,8 +74,7 @@ fn check_filter_matching() {
 
             let request_res = Request::new(&req.url, &req.sourceUrl, &req.r#type);
             // The dataset has cases where URL is set to just "http://" or "https://", which we do not support
-            if request_res.is_ok() {
-                let request = request_res.unwrap();
+            if let Ok(request) = request_res {
                 assert!(
                     network_filter.matches(&request, &mut RegexManager::default()),
                     "Expected {} to match {} at {}, typed {}",
@@ -104,8 +103,8 @@ fn check_engine_matching() {
         }
         for filter in req.filters {
             let opts = ParseOptions::default();
-            let mut engine = Engine::from_rules_debug(&[filter.clone()], opts);
-            let resources = build_resources_from_filters(&[filter.clone()]);
+            let mut engine = Engine::from_rules_debug(std::slice::from_ref(&filter), opts);
+            let resources = build_resources_from_filters(std::slice::from_ref(&filter));
             engine.use_resources(resources);
 
             let network_filter_res = NetworkFilter::parse(&filter, true, opts);