Skip to content

Commit 506fc17

Browse files
committed
Review from @anton-edm
1 parent 64c2b49 commit 506fc17

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/cosmetic_filter_cache_builder.rs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,7 @@ impl<'a, B: FlatBuilder<'a>> FlatSerialize<'a, B> for HostnameRule {
5959
}
6060

6161
#[derive(Default, Clone)]
62-
struct StringVector {
63-
data: Vec<String>,
64-
}
62+
struct StringVector(Vec<String>);
6563

6664
#[derive(Default)]
6765
pub(crate) struct CosmeticFilterCacheBuilder {
@@ -120,7 +118,7 @@ impl CosmeticFilterCacheBuilder {
120118
let selectors = self
121119
.complex_class_rules
122120
.get_or_insert(class, StringVector::default());
123-
selectors.data.push(selector);
121+
selectors.0.push(selector);
124122
}
125123
}
126124
} else if selector.starts_with('#') {
@@ -133,7 +131,7 @@ impl CosmeticFilterCacheBuilder {
133131
let selectors = self
134132
.complex_id_rules
135133
.get_or_insert(id, StringVector::default());
136-
selectors.data.push(selector);
134+
selectors.0.push(selector);
137135
}
138136
}
139137
} else {
@@ -221,7 +219,7 @@ impl<'a, B: FlatBuilder<'a>> FlatSerialize<'a, B> for StringVector {
221219
type Output = WIPOffset<fb::StringVector<'a>>;
222220

223221
fn serialize(value: Self, builder: &mut B) -> WIPOffset<fb::StringVector<'a>> {
224-
let v = FlatSerialize::serialize(value.data, builder);
222+
let v = FlatSerialize::serialize(value.0, builder);
225223
fb::StringVector::create(
226224
builder.raw_builder(),
227225
&fb::StringVectorArgs { data: Some(v) },

src/flatbuffers/containers/fb_index.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,11 @@ use flatbuffers::{Follow, Vector};
88
/// Note: it intentionally returns values using a copy, because it's faster
99
/// than by reference.
1010
pub(crate) trait FbIndex<I> {
11+
/// Returns the number of elements.
1112
fn len(&self) -> usize;
13+
14+
/// Returns a copy of the value at the given index.
15+
/// 'index' must be in range [0, len()), otherwise panics.
1216
fn get(&self, index: usize) -> I;
1317
}
1418

0 commit comments

Comments
 (0)