Skip to content

Location: Street Address is adding one extra div #44

@metodiew

Description

@metodiew

Hey guys,

We had an issue with one of our websites- when you a street name, you have an opening div https://github.com/brainstormforce/all-in-one-schemaorg-rich-snippets/blob/master/functions.php#L999, but if you don't fill the field, you have an extra closing </div> here https://github.com/brainstormforce/all-in-one-schemaorg-rich-snippets/blob/master/functions.php#L1009

I've fixed the issue, adding the same check if(trim($service_street) != "") for the closing </div> item, even if it doesn't WordPress Coding Standards, which seems to be working fine for the project I'm working on.

Would you check the submitted PR and see if there is anything else that needs to be fixed?

Cheers

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions