fix: update on import done

Fixes #1131

Author: philippfromme

src/render/BpmnPropertiesPanel.js

@@ -135,20 +135,20 @@ export default function BpmnPropertiesPanel(props) {
     };
   }, [ selectedElement ]);
 
-  // (2c) root element changed
+  // (2c) import done
   useEffect(() => {
-    const onRootAdded = (e) => {
-      const element = e.element;
+    const onImportDone = () => {
+      const rootElement = canvas.getRootElement();
 
-      _update(element);
+      _update(rootElement);
     };
 
-    eventBus.on('root.added', onRootAdded);
+    eventBus.on('import.done', onImportDone);
 
     return () => {
-      eventBus.off('root.added', onRootAdded);
+      eventBus.off('import.done', onImportDone);
     };
-  }, [ selectedElement ]);
+  }, []);
 
   // (2d) provided entries changed
   useEffect(() => {

test/spec/BpmnPropertiesPanel.spec.js

@@ -225,7 +225,7 @@ describe('<BpmnPropertiesPanel>', function() {
     });
 
 
-    it('should update on root element changed', function() {
+    it('should update on import done', function() {
 
       // given
       const updateSpy = sinon.spy();
@@ -237,7 +237,7 @@ describe('<BpmnPropertiesPanel>', function() {
       createBpmnPropertiesPanel({ container, eventBus });
 
       // when
-      eventBus.fire('root.added', { element: noopElement });
+      eventBus.fire('import.done');
 
       // then
       expect(updateSpy).to.have.been.calledWith({
@@ -450,16 +450,24 @@ function createBpmnPropertiesPanel(options = {}) {
   } = options;
 
   let {
+    canvas,
     elementRegistry
   } = options;
 
+  if (!canvas) {
+    canvas = {
+      getRootElement: () => noopElement
+    };
+  }
+
   if (!elementRegistry) {
     elementRegistry = new elementRegistryMock();
     elementRegistry.setElements([ element ]);
   }
 
   const injector = new injectorMock({
     ...options,
+    canvas,
     elementRegistry
   });
 

test/spec/mocks/index.js

@@ -60,7 +60,7 @@ export class Injector {
     }
 
     if (type === 'canvas') {
-      return new Canvas();
+      return this._options.canvas || new Canvas();
     }
   }
 }