ext/exif: Voidify exif_file_sections_free()

Girgias · Girgias · commit 8a713c1e90f3 · 2025-03-28T18:39:15.000Z
This always returned true, and the return value was never checked anyway
diff --git a/ext/exif/exif.c b/ext/exif/exif.c
@@ -2157,7 +2157,7 @@ static int exif_file_sections_realloc(image_info_type *ImageInfo, int section_in
 /* {{{ exif_file_section_free
    Discard all file_sections in ImageInfo
 */
-static bool exif_file_sections_free(image_info_type *ImageInfo)
+static void exif_file_sections_free(image_info_type *ImageInfo)
 {
 	int i;
 
@@ -2168,7 +2168,6 @@ static bool exif_file_sections_free(image_info_type *ImageInfo)
 	}
 	EFREE_IF(ImageInfo->file.list);
 	ImageInfo->file.count = 0;
-	return true;
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -2157,7 +2157,7 @@ static int exif_file_sections_realloc(image_info_type *ImageInfo, int section_in`
`2157`	`2157`	`/* {{{ exif_file_section_free`
`2158`	`2158`	`Discard all file_sections in ImageInfo`
`2159`	`2159`	`*/`
`2160`		`-static bool exif_file_sections_free(image_info_type *ImageInfo)`
	`2160`	`+static void exif_file_sections_free(image_info_type *ImageInfo)`
`2161`	`2161`	`{`
`2162`	`2162`	`int i;`
`2163`	`2163`
`@@ -2168,7 +2168,6 @@ static bool exif_file_sections_free(image_info_type *ImageInfo)`
`2168`	`2168`	`}`
`2169`	`2169`	`EFREE_IF(ImageInfo->file.list);`
`2170`	`2170`	`ImageInfo->file.count = 0;`
`2171`		`- return true;`
`2172`	`2171`	`}`
`2173`	`2172`	`/* }}} */`
`2174`	`2173`