add more tests and fix a memory error

Author: withinboredom

Zend/zend_namespaces.c

@@ -22,7 +22,7 @@
 #include "zend_hash.h"
 
 zend_class_entry *create_namespace(zend_string *name) {
-   zend_class_entry *ns = pemalloc(sizeof(zend_class_entry), 0);
+   zend_class_entry *ns = malloc(sizeof(zend_class_entry));
    zend_initialize_class_data(ns, 1);
    ns->type = ZEND_NAMESPACE_CLASS;
    ns->ce_flags |= ZEND_ACC_UNINSTANTIABLE;
@@ -39,8 +39,8 @@ static zend_class_entry *insert_namespace(const zend_string *name) {
    const char *pos = start;
    size_t len = 0;
 
-   while (pos < end) {
-      if (*pos == '\\') {
+   while (pos <= end) {
+      if (pos == end || *pos == '\\') {
          len = pos - start;
          zend_string *needle = zend_string_init(ZSTR_VAL(name), len, 0);
 
@@ -100,10 +100,6 @@ void zend_destroy_namespaces(void) {
       zend_hash_destroy(EG(namespaces));
       FREE_HASHTABLE(EG(namespaces));
       EG(namespaces) = NULL;
-   }
-
-   if (EG(global_namespace) != NULL) {
-      pefree(EG(global_namespace), 0);
       EG(global_namespace) = NULL;
    }
 }

Zend/zend_opcode.c

@@ -432,6 +432,7 @@ ZEND_API void destroy_zend_class(zval *zv)
 			}
 			break;
 		case ZEND_INTERNAL_CLASS:
+		case ZEND_NAMESPACE_CLASS:
 			if (ce->doc_comment) {
 				zend_string_release_ex(ce->doc_comment, 1);
 			}

tests/classes/inner_classes/simple_declaration_005.phpt

@@ -0,0 +1,34 @@
+--TEST--
+failed inheritance
+--FILE--
+<?php
+
+class Outer {
+    public class Middle {
+    }
+    public static function testSelf(): Middle {
+        return new Middle();
+    }
+}
+
+class Outer2 extends Outer {
+    public class Middle {
+    }
+
+    public static function testParent(): Outer\Middle {
+        return new Outer\Middle();
+    }
+
+    public static function testSelf(): Middle {
+        return new Middle();
+    }
+}
+
+var_dump(Outer::testSelf());
+var_dump(Outer2::testParent());
+var_dump(Outer2::testSelf());
+var_dump(Outer2::testSelf());
+
+?>
+--EXPECTF--
+Fatal error: Declaration of Outer2::testSelf(): Outer2\middle must be compatible with Outer::testSelf(): Outer\middle in %s on line %d