Review fixes

* comment simpleflow.swf.executor.Executor#decref_workflow
* remove a missed `print`
* test_dataflow: replace the global decref_workflow removal with
    `patch.object` applied as needed

Signed-off-by: Yves Bastide <yves@botify.com>

Author: ybastide

simpleflow/swf/executor.py

@@ -835,6 +835,9 @@ def replay(self, decision_response):
         return [decision], {}
 
     def decref_workflow(self):
+        """
+        Set the `_workflow` ivar to None in the hope of reducing memory consumption.
+        """
         self._workflow = None
 
     def before_replay(self):

simpleflow/swf/process/decider/base.py

@@ -62,7 +62,6 @@ def __init__(self, workflow_executors, domain, task_list, nb_retries=3,
         :type  workflow_executors: list[simpleflow.swf.executor.Executor]
 
         """
-        print(ex._workflow for ex in workflow_executors)
         self._workflow_name = '{}'.format(','.join(
             [
                 ex.workflow_class.name for ex in workflow_executors

tests/test_simpleflow/test_dataflow.py

@@ -39,7 +39,7 @@
 )
 
 
-Executor.decref_workflow = lambda _: None  # FIXME use @patch?
+# Note: tests checking the Executor.workflow instance must patch `decref_workflow`.
 
 
 def check_task_scheduled_decision(decision, task):
@@ -220,7 +220,8 @@ def run(self, a):
 
 
 @mock_swf
-def test_workflow_with_before_replay():
+@patch.object(Executor, 'decref_workflow')
+def test_workflow_with_before_replay(mock_decref_workflow):
     workflow = ATestDefinitionWithBeforeReplay
     executor = Executor(DOMAIN, workflow)
 
@@ -250,7 +251,8 @@ def run(self, a):
 
 
 @mock_swf
-def test_workflow_with_after_replay():
+@patch.object(Executor, 'decref_workflow')
+def test_workflow_with_after_replay(mock_decref_workflow):
     workflow = ATestDefinitionWithAfterReplay
     executor = Executor(DOMAIN, workflow)
 
@@ -279,7 +281,8 @@ def run(self, a):
 
 
 @mock_swf
-def test_workflow_with_after_closed():
+@patch.object(Executor, 'decref_workflow')
+def test_workflow_with_after_closed(mock_decref_workflow):
     workflow = ATestDefinitionWithAfterClosed
     executor = Executor(DOMAIN, workflow)
 
@@ -1070,7 +1073,8 @@ def run(self):
 
 
 @mock_swf
-def test_workflow_failed_from_definition():
+@patch.object(Executor, 'decref_workflow')
+def test_workflow_failed_from_definition(mock_decref_workflow):
     workflow = ATestDefinitionFailWorkflow
     executor = Executor(DOMAIN, workflow)
     history = builder.History(workflow)
@@ -1112,7 +1116,8 @@ def run(self):
 
 
 @mock_swf
-def test_workflow_activity_raises_on_failure():
+@patch.object(Executor, 'decref_workflow')
+def test_workflow_activity_raises_on_failure(mock_decref_workflow):
     workflow = ATestDefinitionActivityRaisesOnFailure
     executor = Executor(DOMAIN, workflow)
     history = builder.History(workflow)
@@ -1150,7 +1155,8 @@ def run(self):
 
 
 @mock_swf
-def test_on_failure_callback():
+@patch.object(Executor, 'decref_workflow')
+def test_on_failure_callback(mock_decref_workflow):
     workflow = ATestOnFailureDefinition
     executor = Executor(DOMAIN, workflow)
     history = builder.History(workflow)