feat(generators): rename updatePartial to update & remove PUT update

Author: phatpham9

generators/app/templates/<%= compNameParamCasePlural %>/controller.ts

@@ -57,25 +57,14 @@ const get = (req: Request, res: Response, next: NextFunction): void => {
   }
 };
 
-const updatePartial = (
+const update = (
   req: Request,
   res: Response,
   next: NextFunction,
 ): void => {
-  try {
-    // TODO: update partial object
-    const object = { ...(req as MyRequest)[ENTITY], ...req.body };
-
-    res.send(object);
-  } catch (err) {
-    next(new HttpError(err.code ?? StatusCodes.INTERNAL_SERVER_ERROR, err));
-  }
-};
-
-const update = (req: Request, res: Response, next: NextFunction): void => {
   try {
     // TODO: update object
-    const object = { ...req.body };
+    const object = { ...(req as MyRequest)[ENTITY], ...req.body };
 
     res.send(object);
   } catch (err) {
@@ -92,4 +81,4 @@ const del = (req: Request, res: Response, next: NextFunction): void => {
   }
 };
 
-export default { getById, list, create, get, updatePartial, update, del };
+export default { getById, list, create, get, update, del };

generators/app/templates/<%= compNameParamCasePlural %>/index.ts

@@ -16,8 +16,7 @@ const routes = (_: RouteOptions): Router => {
   router
     .route('/:id')
     .get(controller.get)
-    .patch(controller.updatePartial)
-    .put(controller.update)
+    .patch(controller.update)
     .delete(controller.del);
 
   return router;

generators/with-mongo/templates/<%= compNameParamCasePlural %>/controller.ts

@@ -76,25 +76,6 @@ const get = (req: Request, res: Response, next: NextFunction): void => {
   }
 };
 
-const updatePartial = async (
-  req: Request,
-  res: Response,
-  next: NextFunction,
-): Promise<void> => {
-  try {
-    console.log((req as MyRequest)[ENTITY]);
-    // update partial object
-    const object = await repository.updatePartial(
-      (req as MyRequest)[ENTITY].id,
-      req.body,
-    );
-
-    res.send(object);
-  } catch (err) {
-    next(new HttpError(err.code ?? StatusCodes.INTERNAL_SERVER_ERROR, err));
-  }
-};
-
 const update = async (
   req: Request,
   res: Response,
@@ -128,4 +109,4 @@ const del = async (
   }
 };
 
-export default { getById, list, create, get, updatePartial, update, del };
+export default { getById, list, create, get, update, del };

generators/with-mongo/templates/<%= compNameParamCasePlural %>/index.ts

@@ -16,8 +16,7 @@ const routes = (_: RouteOptions): Router => {
   router
     .route('/:id')
     .get(controller.get)
-    .patch(controller.updatePartial)
-    .put(controller.update)
+    .patch(controller.update)
     .delete(controller.del);
 
   return router;

generators/with-mongo/templates/<%= compNameParamCasePlural %>/repository.ts

@@ -28,20 +28,6 @@ const get = async (id: string): Promise<<%= compNamePascalCase %>> => {
   return transform(document);
 };
 
-const updatePartial = async (id: string, object: Omit<<%= compNamePascalCase %>, 'id'>): Promise<<%= compNamePascalCase %>> => {
-  // get document
-  const document = await Model.findById(id).exec();
-  if (document === null) {
-    throw new MyError('Document not found');
-  }
-
-  // update partial document
-  document.set(object);
-  await document.save();
-
-  return transform(document);
-};
-
 const update = async (id: string, object: Omit<<%= compNamePascalCase %>, 'id'>): Promise<<%= compNamePascalCase %>> => {
   // get document
   const document = await Model.findById(id).exec();
@@ -50,7 +36,7 @@ const update = async (id: string, object: Omit<<%= compNamePascalCase %>, 'id'>)
   }
 
   // update document
-  document.overwrite(object);
+  document.set(object);
   await document.save();
 
   return transform(document);
@@ -78,4 +64,4 @@ const transform = (document: Document): <%= compNamePascalCase %> => {
   return { ...restObject, id };
 };
 
-export default { list, create, get, updatePartial, update, del };
+export default { list, create, get, update, del };

generators/with-postgres/templates/<%= compNameParamCasePlural %>/controller.ts

@@ -76,25 +76,6 @@ const get = (req: Request, res: Response, next: NextFunction): void => {
   }
 };
 
-const updatePartial = async (
-  req: Request,
-  res: Response,
-  next: NextFunction,
-): Promise<void> => {
-  try {
-    console.log((req as MyRequest)[ENTITY]);
-    // update partial object
-    const object = await repository.updatePartial(
-      (req as MyRequest)[ENTITY].id,
-      req.body,
-    );
-
-    res.send(object);
-  } catch (err) {
-    next(new HttpError(err.code ?? StatusCodes.INTERNAL_SERVER_ERROR, err));
-  }
-};
-
 const update = async (
   req: Request,
   res: Response,
@@ -128,4 +109,4 @@ const del = async (
   }
 };
 
-export default { getById, list, create, get, updatePartial, update, del };
+export default { getById, list, create, get, update, del };

generators/with-postgres/templates/<%= compNameParamCasePlural %>/index.ts

@@ -16,8 +16,7 @@ const routes = (_: RouteOptions): Router => {
   router
     .route('/:id')
     .get(controller.get)
-    .patch(controller.updatePartial)
-    .put(controller.update)
+    .patch(controller.update)
     .delete(controller.del);
 
   return router;

generators/with-postgres/templates/<%= compNameParamCasePlural %>/repository.ts

@@ -28,23 +28,6 @@ const get = async (id: number): Promise<<%= compNamePascalCase %>> => {
   return transform(instance);
 };
 
-const updatePartial = async (
-  id: number,
-  object: Omit<<%= compNamePascalCase %>, 'id'>,
-): Promise<<%= compNamePascalCase %>> => {
-  // get instance
-  const instance = await Model.findByPk(id);
-  if (instance === null) {
-    throw new MyError('Instance not found');
-  }
-
-  // update partial instance
-  instance.set(object);
-  await instance.save();
-
-  return transform(instance);
-};
-
 const update = async (
   id: number,
   object: Omit<<%= compNamePascalCase %>, 'id'>,
@@ -56,7 +39,7 @@ const update = async (
   }
 
   // update instance
-  instance.set({ id, ...object }, { reset: true });
+  instance.set(object);
   await instance.save();
 
   return transform(instance);
@@ -80,4 +63,4 @@ const transform = (instance: Instance): <%= compNamePascalCase %> => {
   return instance.toJSON() as <%= compNamePascalCase %>;
 };
 
-export default { list, create, get, updatePartial, update, del };
+export default { list, create, get, update, del };