[FD1 - 2] 서버와 로컬 간의 폴더 정보를 동기화 한다. #134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeongHunTed
approved these changes
Nov 29, 2023
| value: "application/json" | ||
| ) | ||
| let service = NetworkService(customSession: session, urlRequestBuilder: builder) | ||
| let data = try await service.getData() |
Member
There was a problem hiding this comment.
영균님 getData 다음 PR에서 사라지지 않나요? 다음 PR에서 수정할까요? 아니면 Network 모듈 PR 닫고 수정할까요?
| import Foundation | ||
|
|
||
| protocol PrivateCheckListUseCase { | ||
| func fetchAllFolders() async -> Result<[CheckListFolderItem], Error> |
Member
There was a problem hiding this comment.
오 저는 기존에 Bool Type 리턴했는데 Result Type 사용해야겠네용
| return request | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
영균님이 추가해주셨군요 interceptor는 이렇게 사용하도록 하겠습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
완료한 기능 혹은 수정 기능
고민과 해결 과정
폴더 정보를 서버에서 가져오는 로직을 구현했습니다.
스크린샷
테스트 결과(커버리지/테스트 결과)
N/A