style(pmd): rule exclusions

Author: boolivar

buildSrc/src/main/groovy/java-conventions.gradle

@@ -50,6 +50,10 @@ pmd {
     toolVersion = net.sourceforge.pmd.PMDVersion.VERSION
 }
 
+pmdTest {
+    ruleSets = ["test-ruleset.xml"]
+}
+
 tasks.withType(Pmd).configureEach {
     pmdClasspath += files("$rootDir/gradle/config/pmd")
 }

gradle/config/pmd/ruleset.xml

@@ -26,6 +26,11 @@
         <exclude name="ShortVariable"/>
         <exclude name="UseExplicitTypes"/>
     </rule>
+    <rule ref="category/java/codestyle.xml/LinguisticNaming">
+        <properties>
+            <property name="checkSetters" value="false"/>
+        </properties>
+    </rule>
     <rule ref="category/java/codestyle.xml/UseUnderscoresInNumericLiterals">
         <properties>
             <property name="acceptableDecimalLength" value="5"/>
@@ -38,6 +43,8 @@
         <exclude name="DataClass"/>
         <exclude name="LawOfDemeter"/>
         <exclude name="LoosePackageCoupling"/>
+        <exclude name="TooManyMethods"/>
+        <exclude name="UseObjectForClearerAPI"/>
         <exclude name="UseUtilityClass"/>
     </rule>
     <rule ref="category/java/design.xml/NcssCount">
@@ -49,12 +56,7 @@
 
     <rule ref="category/java/errorprone.xml">
         <exclude name="UseProperClassLoader"/>
-    </rule>
-    <rule ref="category/java/errorprone.xml/AvoidLiteralsInIfCondition">
-        <properties>
-            <property name="ignoreMagicNumbers" value="-1,0,1"/>
-            <property name="ignoreExpressions" value="true"/>
-        </properties>
+        <exclude name="AvoidLiteralsInIfCondition"/>
     </rule>
     <rule ref="category/java/errorprone.xml/TestClassWithoutTestCases">
         <properties>

gradle/config/pmd/test-ruleset.xml

@@ -0,0 +1,7 @@
+<?xml version="1.0"?>
+<ruleset name="PMD rule set for tests">
+    <description>Test rule set</description>
+    <rule ref="ruleset.xml">
+        <exclude name="AvoidDuplicateLiterals"/>
+    </rule>
+</ruleset>