fix: SqsOutboundChannelAdapterParser success-channel attribute

boolivar · boolivar · commit ac0d94dc6d50 · 2024-10-12T23:38:39.000+03:00
diff --git a/int-aws-support/src/main/java/org/springframework/integration/aws/config/xml/SqsOutboundChannelAdapterParser.java b/int-aws-support/src/main/java/org/springframework/integration/aws/config/xml/SqsOutboundChannelAdapterParser.java
@@ -20,7 +20,7 @@ protected AbstractBeanDefinition parseConsumer(Element element, ParserContext pa
             .setExpressionValueIfAttributeDefined("message-deduplication-id")
             .setExpressionValueIfAttributeDefined("send-timeout")
             .setPropertyReferenceIfAttributeDefined("message-converter")
-            .setPropertyReferenceIfAttributeDefined("outputChannelName", "success-channel")
+            .setPropertyValueIfAttributeDefined("outputChannelName", "success-channel")
             ;
 
         if (element.hasAttribute("sync")) {
diff --git a/int-aws-support/src/test/java/org/springframework/integration/aws/config/xml/SqsOutboundChannelAdapterParserTest.java b/int-aws-support/src/test/java/org/springframework/integration/aws/config/xml/SqsOutboundChannelAdapterParserTest.java
@@ -38,6 +38,7 @@ void testReader() {
             .extracting(BeanDefinition::getPropertyValues)
                 .matches(properties -> properties.get("async").equals(new TypedStringValue("false")), "async")
                 .matches(properties -> properties.get("messageConverter").equals(new RuntimeBeanReference("msgConv")), "message converter")
+                .matches(properties -> properties.get("outputChannelName").equals(new TypedStringValue("okChannel")), "success channel")
             ;
     }
 }
diff --git a/int-aws-support/src/test/resources/sqs-outbound-channel-adapter.xml b/int-aws-support/src/test/resources/sqs-outbound-channel-adapter.xml
@@ -12,5 +12,6 @@
         sqs="sqsClient"
         sync="true"
         message-converter="msgConv"
-        error-message-strategy="emb"/>
+        error-message-strategy="emb"
+        success-channel="okChannel"/>
 </beans>

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ protected AbstractBeanDefinition parseConsumer(Element element, ParserContext pa`
`20`	`20`	`.setExpressionValueIfAttributeDefined("message-deduplication-id")`
`21`	`21`	`.setExpressionValueIfAttributeDefined("send-timeout")`
`22`	`22`	`.setPropertyReferenceIfAttributeDefined("message-converter")`
`23`		`- .setPropertyReferenceIfAttributeDefined("outputChannelName", "success-channel")`
	`23`	`+ .setPropertyValueIfAttributeDefined("outputChannelName", "success-channel")`
`24`	`24`	`;`
`25`	`25`
`26`	`26`	`if (element.hasAttribute("sync")) {`
Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@ void testReader() {`
`38`	`38`	`.extracting(BeanDefinition::getPropertyValues)`
`39`	`39`	`.matches(properties -> properties.get("async").equals(new TypedStringValue("false")), "async")`
`40`	`40`	`.matches(properties -> properties.get("messageConverter").equals(new RuntimeBeanReference("msgConv")), "message converter")`
	`41`	`+ .matches(properties -> properties.get("outputChannelName").equals(new TypedStringValue("okChannel")), "success channel")`
`41`	`42`	`;`
`42`	`43`	`}`
`43`	`44`	`}`