test: SnsInboundChannelAdapterParserTest

Author: boolivar

int-aws/build.gradle

@@ -5,14 +5,16 @@ plugins {
 dependencies {
     api "org.springframework.integration:spring-integration-aws"
 
+    compileOnly "com.amazonaws:amazon-kinesis-producer:0.15.12"
     compileOnly "io.awspring.cloud:spring-cloud-aws-s3"
     compileOnly "io.awspring.cloud:spring-cloud-aws-sns"
     compileOnly "io.awspring.cloud:spring-cloud-aws-sqs"
-    compileOnly "org.springframework.integration:spring-integration-file"
     compileOnly "org.springframework.integration:spring-integration-http"
-    compileOnly "software.amazon.awssdk:s3-transfer-manager"
+    compileOnly "org.springframework.integration:spring-integration-file"
     compileOnly "software.amazon.kinesis:amazon-kinesis-client:2.6.0"
-    compileOnly "com.amazonaws:amazon-kinesis-producer:0.15.12"
 
     testImplementation "io.github.boolivar:mockito-inline-extension"
+
+    testRuntimeOnly "software.amazon.awssdk:s3-transfer-manager"
+    testRuntimeOnly "jakarta.servlet:jakarta.servlet-api:6.1.0"
 }

int-aws/src/main/java/org/springframework/integration/aws/config/xml/parsers/SnsInboundChannelAdapterParser.java

@@ -20,7 +20,7 @@ protected AbstractBeanDefinition doParse(Element element, ParserContext parserCo
             .setPropertyIfAttributeDefined("error-channel", "errorChannelName")
             .setPropertyIfAttributeDefined("payload-expression", "payloadExpression", ValueFactory.expressionBean())
             .getBeanDefinitionBuilder()
-            .addPropertyReference("requestChannelName", channelName)
+            .addPropertyValue("requestChannelName", channelName)
             .getBeanDefinition();
     }
 }

int-aws/src/test/java/org/springframework/integration/aws/config/xml/parsers/SnsInboundChannelAdapterParserTest.java

@@ -0,0 +1,50 @@
+package org.springframework.integration.aws.config.xml.parsers;
+
+import org.bool.junit.mockito.inline.ConstructionMock;
+
+import org.assertj.core.api.InstanceOfAssertFactories;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mock;
+import org.mockito.MockedConstruction.Context;
+import org.springframework.integration.aws.inbound.SnsInboundChannelAdapter;
+import software.amazon.awssdk.services.sns.SnsClient;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+class SnsInboundChannelAdapterParserTest extends ParserTestBase {
+
+    @Mock
+    private SnsClient sns;
+
+    @ConstructionMock(SnsInboundChannelAdapter.class)
+    @Test
+    void testAdapter() {
+        registerBean("sns", SnsClient.class, sns);
+
+        var adapter = loadBean(SnsInboundChannelAdapter.class, """
+            <int-aws:sns-inbound-channel-adapter
+                    auto-startup="#{false}"
+                    id="snsica"
+                    channel="c"
+                    sns="sns"
+                    path="/sns/{id},/sns/action/*.do"
+                    error-channel="ec"
+                    payload-expression="pe.exp"
+                    handle-notification-status="#{true}"
+                    send-timeout="#{50}"/>
+            """);
+
+        verify(adapter).setBeanName("snsica");
+        verify(adapter).setAutoStartup(false);
+        verify(adapter).setRequestChannelName("c");
+        verify(adapter).setErrorChannelName("ec");
+        verify(adapter).setPayloadExpression(argThat(e -> "pe.exp".equals(e.getExpressionString())));
+        verify(adapter).setHandleNotificationStatus(true);
+        verify(adapter).setRequestTimeout(50L);
+    }
+
+    void testAdapter(SnsInboundChannelAdapter mock, Context context) {
+        assertThat(context.arguments()).asInstanceOf(InstanceOfAssertFactories.LIST)
+            .contains(sns, new String[] {"/sns/{id}", "/sns/action/*.do"});
+    }
+}