Skip to content

Commit 6707576

Browse files
committed
refactor(int-aws): ParserTestBase from parser-test module
1 parent f88c693 commit 6707576

14 files changed

+56
-79
lines changed

int-aws/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ dependencies {
1313
compileOnly "org.springframework.integration:spring-integration-file"
1414
compileOnly "software.amazon.kinesis:amazon-kinesis-client:2.6.0"
1515

16-
testImplementation "io.github.boolivar:mockito-inline-extension"
16+
testImplementation project(":parser-test")
1717

1818
testRuntimeOnly "software.amazon.awssdk:s3-transfer-manager"
1919
testRuntimeOnly "jakarta.servlet:jakarta.servlet-api"

int-aws/src/test/java/org/springframework/integration/aws/config/xml/parsers/KclMessageDrivenChannelAdapterParserTest.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import org.mockito.MockedStatic;
1313
import org.springframework.core.convert.converter.Converter;
1414
import org.springframework.core.task.TaskExecutor;
15+
import org.springframework.integration.aws.config.xml.parsers.test.ParserTestBase;
1516
import org.springframework.integration.aws.inbound.kinesis.CheckpointMode;
1617
import org.springframework.integration.aws.inbound.kinesis.KclMessageDrivenChannelAdapter;
1718
import org.springframework.integration.aws.inbound.kinesis.ListenerMode;
@@ -53,10 +54,13 @@ class KclMessageDrivenChannelAdapterParserTest extends ParserTestBase {
5354

5455
@Test
5556
void testDefaults(MockedConstruction<KclMessageDrivenChannelAdapter> mocked) {
56-
var adapter = loadBean(KclMessageDrivenChannelAdapter.class, """
57+
parse("""
5758
<int-aws:kcl-message-driven-channel-adapter streams="s"
5859
channel="c"/>
5960
""");
61+
62+
var adapter = getBean(KclMessageDrivenChannelAdapter.class);
63+
6064
assertThat(mocked.constructed())
6165
.singleElement().isSameAs(adapter);
6266
}
@@ -75,12 +79,14 @@ void testKinesisClientConfig(MockedConstruction<KclMessageDrivenChannelAdapter>
7579
dynamoDbMock.when(DynamoDbAsyncClient::create).thenReturn(dynamoDbClient);
7680
cloudWatchMock.when(CloudWatchAsyncClient::create).thenReturn(cloudWatchClient);
7781

78-
var adapter = loadBean(KclMessageDrivenChannelAdapter.class, """
82+
parse("""
7983
<int-aws:kcl-message-driven-channel-adapter streams="s"
8084
channel="c"
8185
kinesis-client="kc"/>
8286
""");
8387

88+
var adapter = getBean(KclMessageDrivenChannelAdapter.class);
89+
8490
assertThat(mocked.constructed())
8591
.singleElement().isSameAs(adapter);
8692
}
@@ -101,7 +107,7 @@ void testAdapter() {
101107
registerBean("gsrd", GlueSchemaRegistryDeserializer.class, glueSchemaRegistryDeserializer);
102108
registerBean("sis", InitialPositionInStreamExtended.class, streamInitialSequence);
103109

104-
var adapter = loadBean(KclMessageDrivenChannelAdapter.class, """
110+
parse("""
105111
<int-aws:kcl-message-driven-channel-adapter streams="s"
106112
id="i"
107113
channel="c"
@@ -131,6 +137,8 @@ void testAdapter() {
131137
worker-id="wid"/>
132138
""");
133139

140+
var adapter = getBean(KclMessageDrivenChannelAdapter.class);
141+
134142
verify(adapter).setBindSourceRecord(true);
135143
verify(adapter).setCheckpointMode(CheckpointMode.batch);
136144
verify(adapter).setCheckpointsInterval(70L);

int-aws/src/test/java/org/springframework/integration/aws/config/xml/parsers/KinesisMessageDrivenChannelAdapterParserTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import org.mockito.Mock;
88
import org.mockito.MockedConstruction.Context;
99
import org.springframework.core.convert.converter.Converter;
10+
import org.springframework.integration.aws.config.xml.parsers.test.ParserTestBase;
1011
import org.springframework.integration.aws.inbound.kinesis.CheckpointMode;
1112
import org.springframework.integration.aws.inbound.kinesis.KinesisMessageDrivenChannelAdapter;
1213
import org.springframework.integration.aws.inbound.kinesis.KinesisShardOffset;
@@ -65,7 +66,7 @@ void testAdapter() {
6566
registerBean("slf", Function.class, shardListFilter);
6667
registerBean("sis", KinesisShardOffset.class, streamInitialSequence);
6768

68-
var adapter = loadBean(KinesisMessageDrivenChannelAdapter.class, """
69+
parse("""
6970
<int-aws:kinesis-message-driven-channel-adapter kinesis-client="kc" streams="a,b,c"
7071
id="i"
7172
channel="c"
@@ -92,6 +93,8 @@ void testAdapter() {
9293
stream-initial-sequence="sis"/>
9394
""");
9495

96+
var adapter = getBean(KinesisMessageDrivenChannelAdapter.class);
97+
9598
verify(adapter).setBindSourceRecord(true);
9699
verify(adapter).setCheckpointMode(CheckpointMode.batch);
97100
verify(adapter).setCheckpointStore(checkpointStore);

int-aws/src/test/java/org/springframework/integration/aws/config/xml/parsers/KinesisOutboundChannelAdapterParserTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import org.junit.jupiter.api.Test;
66
import org.mockito.Mock;
77
import org.mockito.MockedConstruction.Context;
8+
import org.springframework.integration.aws.config.xml.parsers.test.ParserTestBase;
89
import org.springframework.integration.aws.outbound.KinesisMessageHandler;
910
import org.springframework.integration.mapping.OutboundMessageMapper;
1011
import org.springframework.messaging.converter.MessageConverter;
@@ -30,7 +31,7 @@ void testMessageHandler() {
3031
registerBean("ehm", OutboundMessageMapper.class, messageMapper);
3132
registerBean("mc", MessageConverter.class, messageConverter);
3233

33-
var handler = loadBean(KinesisMessageHandler.class, """
34+
parse("""
3435
<int-aws:kinesis-outbound-channel-adapter kinesis-client="kc"
3536
id="i"
3637
channel="c"
@@ -46,6 +47,8 @@ void testMessageHandler() {
4647
sequence-number-expression="headers.exp"/>
4748
""");
4849

50+
var handler = getBean(KinesisMessageHandler.class);
51+
4952
verify(handler).setStream("s");
5053
verify(handler).setAsync(true);
5154
verify(handler).setEmbeddedHeadersMapper(messageMapper);

int-aws/src/test/java/org/springframework/integration/aws/config/xml/parsers/KplOutboundChannelAdapterParserTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import org.junit.jupiter.api.Test;
77
import org.mockito.Mock;
88
import org.mockito.MockedConstruction.Context;
9+
import org.springframework.integration.aws.config.xml.parsers.test.ParserTestBase;
910
import org.springframework.integration.aws.outbound.KplMessageHandler;
1011
import org.springframework.integration.mapping.OutboundMessageMapper;
1112
import org.springframework.messaging.converter.MessageConverter;
@@ -32,7 +33,7 @@ void testMessageHandler() {
3233
registerBean("ehm", OutboundMessageMapper.class, messageMapper);
3334
registerBean("mc", MessageConverter.class, messageConverter);
3435

35-
var handler = loadBean(KplMessageHandler.class, """
36+
parse("""
3637
<int-aws:kpl-outbound-channel-adapter kinesis-producer="kp"
3738
id="i"
3839
channel="c"
@@ -50,6 +51,8 @@ void testMessageHandler() {
5051
sequence-number-expression="headers.exp"/>
5152
""");
5253

54+
var handler = getBean(KplMessageHandler.class);
55+
5356
verify(handler).setStream("s");
5457
verify(handler).setAsync(true);
5558
verify(handler).setEmbeddedHeadersMapper(messageMapper);

int-aws/src/test/java/org/springframework/integration/aws/config/xml/parsers/ParserTestBase.java

Lines changed: 0 additions & 64 deletions
This file was deleted.

int-aws/src/test/java/org/springframework/integration/aws/config/xml/parsers/S3InboundChannelAdapterParserTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import org.junit.jupiter.api.Test;
77
import org.mockito.Mock;
88
import org.mockito.MockedConstruction.Context;
9+
import org.springframework.integration.aws.config.xml.parsers.test.ParserTestBase;
910
import org.springframework.integration.aws.inbound.S3InboundFileSynchronizer;
1011
import org.springframework.integration.aws.inbound.S3InboundFileSynchronizingMessageSource;
1112
import org.springframework.integration.channel.DirectChannel;
@@ -52,7 +53,7 @@ void testAdapter() {
5253
registerBean("cmp", Comparator.class, comparator);
5354
registerBean("scn", DirectoryScanner.class, scanner);
5455

55-
var messageSource = loadBean(S3InboundFileSynchronizingMessageSource.class, """
56+
parse("""
5657
<int-aws:s3-inbound-channel-adapter
5758
id="s3ica"
5859
channel="c"
@@ -74,6 +75,8 @@ void testAdapter() {
7475
comparator="cmp"/>
7576
""");
7677

78+
var messageSource = getBean(S3InboundFileSynchronizingMessageSource.class);
79+
7780
verify(messageSource).setLocalDirectory(new File("local"));
7881
verify(messageSource).setScanner(scanner);
7982
verify(messageSource).setLocalFilter(fileListFilter);

int-aws/src/test/java/org/springframework/integration/aws/config/xml/parsers/S3InboundStreamingChannelAdapterParserTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import org.junit.jupiter.api.Test;
77
import org.mockito.Mock;
88
import org.mockito.MockedConstruction.Context;
9+
import org.springframework.integration.aws.config.xml.parsers.test.ParserTestBase;
910
import org.springframework.integration.aws.inbound.S3StreamingMessageSource;
1011
import org.springframework.integration.aws.support.S3RemoteFileTemplate;
1112
import org.springframework.integration.aws.support.S3SessionFactory;
@@ -32,7 +33,7 @@ void testAdapter() {
3233
registerBean("sf", S3SessionFactory.class, sessionFactory);
3334
registerBean("cmp", Comparator.class, comparator);
3435

35-
var messageSource = loadBean(S3StreamingMessageSource.class, """
36+
parse("""
3637
<int-aws:s3-inbound-streaming-channel-adapter
3738
id="s3isca"
3839
channel="c"
@@ -46,6 +47,8 @@ void testAdapter() {
4647
/>
4748
""");
4849

50+
var messageSource = getBean(S3StreamingMessageSource.class);
51+
4952
verify(messageSource).setMaxFetchSize(10);
5053
verify(messageSource).setRemoteDirectoryExpression(assertArg(e -> assertThat(e.getExpressionString()).isEqualTo("remote")));
5154
verify(messageSource).setRemoteFileSeparator(";");

int-aws/src/test/java/org/springframework/integration/aws/config/xml/parsers/S3OutboundChannelAdapterParserTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import org.junit.jupiter.api.Test;
77
import org.mockito.Mock;
88
import org.mockito.MockedConstruction.Context;
9+
import org.springframework.integration.aws.config.xml.parsers.test.ParserTestBase;
910
import org.springframework.integration.aws.outbound.S3MessageHandler;
1011
import org.springframework.integration.aws.outbound.S3MessageHandler.Command;
1112
import org.springframework.messaging.Message;
@@ -30,7 +31,7 @@ void testMessageHandler() {
3031
registerBean("sss", S3AsyncClient.class, s3Client);
3132
registerBean("ump", BiConsumer.class, uploadMetadataProvider);
3233

33-
var handler = loadBean(S3MessageHandler.class, """
34+
parse("""
3435
<int-aws:s3-outbound-channel-adapter
3536
id="s3out"
3637
channel="c"
@@ -45,6 +46,8 @@ void testMessageHandler() {
4546
/>
4647
""");
4748

49+
var handler = getBean(S3MessageHandler.class);
50+
4851
verify(handler).setCommand(Command.COPY);
4952
verify(handler).setKeyExpression(argThat(e -> "key.exp".equals(e.getExpressionString())));
5053
verify(handler).setDestinationKeyExpression(argThat(e -> "dest.key.exp".equals(e.getExpressionString())));

int-aws/src/test/java/org/springframework/integration/aws/config/xml/parsers/S3OutboundGatewayParserTest.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import org.junit.jupiter.api.Test;
77
import org.mockito.Mock;
88
import org.mockito.MockedConstruction.Context;
9+
import org.springframework.integration.aws.config.xml.parsers.test.ParserTestBase;
910
import org.springframework.integration.aws.outbound.S3MessageHandler;
1011
import org.springframework.integration.aws.outbound.S3MessageHandler.Command;
1112
import org.springframework.integration.channel.DirectChannel;
@@ -32,7 +33,7 @@ void testMessageHandler() {
3233
registerBean("ump", BiConsumer.class, uploadMetadataProvider);
3334
registerBean("rq", DirectChannel.class, new DirectChannel());
3435

35-
var handler = loadBean(S3MessageHandler.class, """
36+
parse("""
3637
<int-aws:s3-outbound-gateway
3738
id="s3gw"
3839
s3="sss"
@@ -49,6 +50,8 @@ void testMessageHandler() {
4950
upload-metadata-provider="ump"/>
5051
""");
5152

53+
var handler = getBean(S3MessageHandler.class);
54+
5255
verify(handler).setAsync(true);
5356
verify(handler).setCommand(Command.COPY);
5457
verify(handler).setKeyExpression(argThat(e -> "key.exp".equals(e.getExpressionString())));

0 commit comments

Comments
 (0)