refactor: XmlBeanDefinitionBuilder.unsupportedAttributeWarning()

Author: boolivar

int-aws-support/src/main/java/org/springframework/integration/aws/config/xml/SqsOutboundChannelAdapterParser.java

@@ -7,13 +7,12 @@
 import org.springframework.integration.config.xml.AbstractOutboundChannelAdapterParser;
 import org.w3c.dom.Element;
 
-import java.util.List;
-
 public class SqsOutboundChannelAdapterParser extends AbstractOutboundChannelAdapterParser {
 
     @Override
     protected AbstractBeanDefinition parseConsumer(Element element, ParserContext parserContext) {
         var builder = XmlBeanDefinitionBuilder.newInstance(element, parserContext, SqsMessageHandler.class)
+            .unsupportedAttributeWarning("failure-channel", "resource-id-resolver", "error-message-strategy", "async-handler")
             .addConstructorArgReference("sqs")
             .setExpressionValueIfAttributeDefined("queue")
             .setExpressionValueIfAttributeDefined("delay")
@@ -35,12 +34,6 @@ protected AbstractBeanDefinition parseConsumer(Element element, ParserContext pa
             }
         }
 
-        for (var attribute : List.of("failure-channel", "resource-id-resolver", "error-message-strategy", "async-handler")) {
-            if (element.hasAttribute(attribute)) {
-                builder.warning("Attribute " + attribute + " not supported");
-            }
-        }
-
         return builder.build();
     }
 }

int-aws-support/src/main/java/org/springframework/integration/aws/config/xml/XmlBeanDefinitionBuilder.java

@@ -108,6 +108,15 @@ public XmlBeanDefinitionBuilder setPropertyValueIfExclusiveAttributeDefined(Stri
         return this;
     }
 
+    public XmlBeanDefinitionBuilder unsupportedAttributeWarning(String... attributes) {
+        for (var attribute : attributes) {
+            if (element.hasAttribute(attribute)) {
+                warning("'" + attribute + "' attribute not supported");
+            }
+        }
+        return this;
+    }
+
     public XmlBeanDefinitionBuilder warning(String message, Throwable cause) {
         parserContext.getReaderContext().warning(message, element, cause);
         return this;