chore: make getCrossChainSwapOrders fail silently to keep getOrders stable (#885)

Author: nakul1010

sdk/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@gobob/bob-sdk",
-    "version": "4.4.8",
+    "version": "4.4.9",
     "main": "dist/index.js",
     "types": "dist/index.d.ts",
     "scripts": {

sdk/src/gateway/layerzero.ts

@@ -931,12 +931,25 @@ export class LayerZeroGatewayClient extends GatewayApiClient {
         return createOrderGasEstimate * fee;
     }
 
+    /**
+     * Fetches cross-chain swap orders initiated by a given wallet.
+     *
+     * @param _userAddress - Wallet address the message originated from.
+     * @returns Array of normalized cross-chain orders.
+     */
     async getCrossChainSwapOrders(_userAddress: Address): Promise<CrossChainOrder[]> {
         const url = new URL(`https://scan.layerzero-api.com/v1/messages/wallet/${_userAddress}`);
 
         const response = await super.safeFetch(url.toString(), undefined, 'Failed to fetch LayerZero send orders');
 
         if (!response.ok) {
+            if (response.status === 404) {
+                // Note: The API returns an error instead of an empty JSON if the address is not found
+                console.warn('LayerZero send orders not found. Status:', response.status, response.statusText);
+                return [];
+            }
+
+            // For all other errors: throw
             const errorData = await response.json().catch(() => null);
             throw new Error(errorData?.message || 'Failed to fetch LayerZero send orders');
         }

sdk/test/layerzero.test.ts

@@ -43,6 +43,7 @@ import { Hex } from 'viem';
 import { privateKeyToAccount } from 'viem/accounts';
 import { getCrossChainStatus } from '../src/gateway/utils/layerzero';
 import { supportedChainsMapping } from '../src/gateway/utils/common';
+import { EsploraClient, GatewaySDK } from '../src';
 
 describe('LayerZero Tests', () => {
     it.skip('should get chains', async () => {
@@ -143,6 +144,28 @@ describe('LayerZero Tests', () => {
         console.log(txHash);
     }, 120000);
 
+    it.skip(
+        'fetches LayerZero orders and cross-chain swap orders correctly',
+        async () => {
+            const client = new LayerZeroGatewayClient();
+
+            // Case 1: Address with no cross-chain swap orders and no with gateway orders
+            const noCrossChainSwapAddress = '0x0555E30da8f98308EdB960aa94C0Db47230d2B9c';
+            let crossChainSwapOrders = await client.getCrossChainSwapOrders(noCrossChainSwapAddress);
+            expect(crossChainSwapOrders.length).toBeGreaterThanOrEqual(0); // if expected
+            let allOrders = await client.getOrders(noCrossChainSwapAddress);
+            expect(allOrders).toHaveLength(0);
+
+            // Case 2: Address that has done cross-chain swaps and gateway orders
+            const swapAddress = '0x9BD3befca3660D38F5125C48BB21bEf3e8789787';
+            crossChainSwapOrders = await client.getCrossChainSwapOrders(swapAddress);
+            expect(crossChainSwapOrders.length).toBeGreaterThanOrEqual(1);
+            allOrders = await client.getOrders(swapAddress);
+            expect(allOrders.length).toBeGreaterThanOrEqual(1);
+        },
+        { timeout: 30000 }
+    );
+
     it.skip('should get an offramp quote and execute it', async () => {
         const client = new LayerZeroGatewayClient();
         const layerZeroClient = new LayerZeroClient();