Skip to content

Commit ff02be0

Browse files
Gautam R Akuba-moo
authored andcommitted
bnxt_en: Fix null pointer dereference in bnxt_bs_trace_check_wrap()
With older FW, we may get the ASYNC_EVENT_CMPL_EVENT_ID_DBG_BUF_PRODUCER for FW trace data type that has not been initialized. This will result in a crash in bnxt_bs_trace_type_wrap(). Add a guard to check for a valid magic_byte pointer before proceeding. Fixes: 84fcd94 ("bnxt_en: Manage the FW trace context memory") Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Reviewed-by: Shruti Parab <shruti.parab@broadcom.com> Signed-off-by: Gautam R A <gautam-r.a@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Link: https://patch.msgid.link/20251104005700.542174-4-michael.chan@broadcom.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent deb8eb3 commit ff02be0

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+1
-1
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2149,7 +2149,7 @@ struct bnxt_bs_trace_info {
21492149
static inline void bnxt_bs_trace_check_wrap(struct bnxt_bs_trace_info *bs_trace,
21502150
u32 offset)
21512151
{
2152-
if (!bs_trace->wrapped &&
2152+
if (!bs_trace->wrapped && bs_trace->magic_byte &&
21532153
*bs_trace->magic_byte != BNXT_TRACE_BUF_MAGIC_BYTE)
21542154
bs_trace->wrapped = 1;
21552155
bs_trace->last_offset = offset;

0 commit comments

Comments
 (0)