bnxt_en: Fix a possible memory leak in bnxt_ptp_init

Kalesh AP · kuba-moo · commit deb8eb391643 · 2025-11-04T17:25:19.000-08:00
In bnxt_ptp_init(), when ptp_clock_register() fails, the driver is not freeing the memory allocated for ptp_info->pin_config. Fix it to unconditionally free ptp_info->pin_config in bnxt_ptp_free(). Fixes: caf3eed ("bnxt_en: 1PPS support for 5750X family chips") Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Link: https://patch.msgid.link/20251104005700.542174-3-michael.chan@broadcom.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
@@ -1051,9 +1051,9 @@ static void bnxt_ptp_free(struct bnxt *bp)
 	if (ptp->ptp_clock) {
 		ptp_clock_unregister(ptp->ptp_clock);
 		ptp->ptp_clock = NULL;
-		kfree(ptp->ptp_info.pin_config);
-		ptp->ptp_info.pin_config = NULL;
 	}
+	kfree(ptp->ptp_info.pin_config);
+	ptp->ptp_info.pin_config = NULL;
 }
 
 int bnxt_ptp_init(struct bnxt *bp)

Original file line number	Diff line number	Diff line change
`@@ -1051,9 +1051,9 @@ static void bnxt_ptp_free(struct bnxt *bp)`
`1051`	`1051`	`if (ptp->ptp_clock) {`
`1052`	`1052`	`ptp_clock_unregister(ptp->ptp_clock);`
`1053`	`1053`	`ptp->ptp_clock = NULL;`
`1054`		`- kfree(ptp->ptp_info.pin_config);`
`1055`		`- ptp->ptp_info.pin_config = NULL;`
`1056`	`1054`	`}`
	`1055`	`+ kfree(ptp->ptp_info.pin_config);`
	`1056`	`+ ptp->ptp_info.pin_config = NULL;`
`1057`	`1057`	`}`
`1058`	`1058`
`1059`	`1059`	`int bnxt_ptp_init(struct bnxt *bp)`