Skip to content

Commit dcc1666

Browse files
committed
cpufreq: intel_pstate: EAS: Increase cost for CPUs using L3 cache
JIRA: https://issues.redhat.com/browse/RHEL-112493 Conflicts: needed to add include of linux/cacheinfo.h as RHEL does not have upstream c51a4f1 commit 05cf8b8 Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Date: Tue May 6 22:47:53 2025 +0200 cpufreq: intel_pstate: EAS: Increase cost for CPUs using L3 cache On some hybrid platforms some efficient CPUs (E-cores) are not connected to the L3 cache, but there are no other differences between them and the other E-cores that use L3. In that case, it is generally more efficient to run "light" workloads on the E-cores that do not use L3 and allow all of the cores using L3, including P-cores, to go into idle states. For this reason, slightly increase the cost for all CPUs sharing the L3 cache to make EAS prefer CPUs that do not use it to the other CPUs of the same type (if any). Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Link: https://patch.msgid.link/2032776.usQuhbGJ8B@rjwysocki.net Signed-off-by: David Arcari <darcari@redhat.com>
1 parent b78543d commit dcc1666

File tree

1 file changed

+18
-0
lines changed

1 file changed

+18
-0
lines changed

drivers/cpufreq/intel_pstate.c

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
#include <linux/bitfield.h>
3030
#include <trace/events/power.h>
3131
#include <linux/units.h>
32+
#include <linux/cacheinfo.h>
3233

3334
#include <asm/cpu.h>
3435
#include <asm/div64.h>
@@ -982,6 +983,7 @@ static int hybrid_get_cost(struct device *dev, unsigned long freq,
982983
unsigned long *cost)
983984
{
984985
struct pstate_data *pstate = &all_cpu_data[dev->id]->pstate;
986+
struct cpu_cacheinfo *cacheinfo = get_cpu_cacheinfo(dev->id);
985987

986988
/*
987989
* The smaller the perf-to-frequency scaling factor, the larger the IPC
@@ -994,6 +996,22 @@ static int hybrid_get_cost(struct device *dev, unsigned long freq,
994996
* of the same type in different "utilization bins" is different.
995997
*/
996998
*cost = div_u64(100ULL * INTEL_PSTATE_CORE_SCALING, pstate->scaling) + freq;
999+
/*
1000+
* Increase the cost slightly for CPUs able to access L3 to avoid
1001+
* touching it in case some other CPUs of the same type can do the work
1002+
* without it.
1003+
*/
1004+
if (cacheinfo) {
1005+
unsigned int i;
1006+
1007+
/* Check if L3 cache is there. */
1008+
for (i = 0; i < cacheinfo->num_leaves; i++) {
1009+
if (cacheinfo->info_list[i].level == 3) {
1010+
*cost += 2;
1011+
break;
1012+
}
1013+
}
1014+
}
9971015

9981016
return 0;
9991017
}

0 commit comments

Comments
 (0)